Remove deleted argument to VisitSubkernelsAndSelf#182
Merged
cartermp merged 1 commit intofslaborg:mainfrom Nov 14, 2024
Merged
Conversation
Contributor
Author
|
It looks like this might need changes similar to #172. |
|
You can also remove the binary dependency on .NET Interactive entirely using convention-based formatting. plotly/Plotly.NET#476 (comment) |
cartermp
approved these changes
Nov 14, 2024
Collaborator
|
@markples @jonsequitur I'll see if I can give building and updating this thing a whirl this afternoon. It was painful to update all the things late last year in part due to the build dependencies, but it's likely different now. |
Collaborator
|
Okay, this is now in latest main alongside an update to packages, tfms, etc. I now need to remember how to log into nuget so I can actually update packages. Ugh. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In dotnet/interactive#3563, the
VisitSubkernelsAndSelfmethod (insrc/Microsoft.DotNet.Interactive/KernelExtensions.cs) was updated to remove therecursiveargument, which breaks XPlot:public static void VisitSubkernelsAndSelf( this Kernel kernel, - Action<Kernel> onVisit, - bool recursive = false) + Action<Kernel> onVisit) { if (kernel is null)This should fix the binding, though I haven't built or tested anything yet.
Two possible issues:
Microsoft.DotNet.Interactivebecause they had a default value for the deleted argument, but binaries will need to run against compatible versions because the signature of the call is explicit in the IL. Specifically, new XPlot won't work with old Interactive.VisitSubkernelsAndSelfis only non-recursive, so this is a behavior change from before (which passedtrue).