Closed
Conversation
Contributor
|
So I expanded on your work a bit and extracted css variables for the colors you changed. (I didn't do the Font but that can be an exercise for later). Example of changing light/dark dynamically |
Closed
Collaborator
|
Closing in favour of #861 |
Member
Author
|
Ok, does the "modern" support a dark theme, or should I re-work similar PR? |
Collaborator
|
It does out of the box. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was using this project to replace generate.fsx docs for SQLProvider. Worked pretty well, but the default colour schema is a bit "from 70s sofa" theme and I missed the dark more-VS-style-editor theme. So I added this theme file, it's not perfect, but feel free to improve.
I don't know how this project works, but I just run
--parameters fsdocs-theme darkcodeand even though all the docs says not supported, when I copied the file to my output content directory, behold!The darkcode, this PR:

...versus the default scheme:

But as this was initial version, I definitely want to keep the original too, because it might feel comfy for some.