Skip to content

improve: Make it easier for other people to follow package-maker#52

Merged
fingolfin merged 6 commits intogap-packages:masterfrom
MaxFork:max-updates
Mar 16, 2026
Merged

improve: Make it easier for other people to follow package-maker#52
fingolfin merged 6 commits intogap-packages:masterfrom
MaxFork:max-updates

Conversation

@BaseMax
Copy link
Copy Markdown
Contributor

@BaseMax BaseMax commented Apr 9, 2025

No description provided.

@james-d-mitchell
Copy link
Copy Markdown
Contributor

james-d-mitchell commented Apr 9, 2025

@BaseMax thanks for the comment, but I'm afraid I don't understand what you are suggesting, can you please elaborate?

@BaseMax
Copy link
Copy Markdown
Contributor Author

BaseMax commented Apr 9, 2025 •
edited
Loading

We are now in the developing room with Max Horn, I just mentioned this in-person there if you are here.

1- It generates the new package directory in your current directory, not in pkg dir. It wasted up to 1h my time yesterday to discover where it generates the package directory.
2- Mention it's possible to install it by InstallPackage command if you are familiar with PackageManager.

Many thanks.

james-d-mitchell
james-d-mitchell reviewed Apr 9, 2025
View reviewed changes
james-d-mitchell
james-d-mitchell suggested changes Apr 9, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@james-d-mitchell james-d-mitchell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current sentence doesn't completely make sense (paraphrasing"PackageManager installs packages automatically by leveraging PackageManager"), I've added a suggested other wording, which is less repetitive.

@BaseMax @james-d-mitchell
Update README.md
82497f3 
Co-authored-by: James Mitchell <james-d-mitchell@users.noreply.github.com>
@BaseMax
Copy link
Copy Markdown
Contributor Author

BaseMax commented Apr 9, 2025

Many thanks

fingolfin
fingolfin reviewed Apr 9, 2025
View reviewed changes
fingolfin
fingolfin reviewed Apr 9, 2025
View reviewed changes
BaseMax and others added 2 commits April 10, 2025 15:45
@BaseMax @fingolfin
Update README.md
bc6c245 
Co-authored-by: Max Horn <max@quendi.de>
@BaseMax @fingolfin
Update README.md
23d27f5 
Co-authored-by: Max Horn <max@quendi.de>
fingolfin
fingolfin reviewed Mar 16, 2026
View reviewed changes
fingolfin
fingolfin reviewed Mar 16, 2026
View reviewed changes
@fingolfin
Copy link
Copy Markdown
Member

fingolfin commented Mar 16, 2026

@BaseMax it seems I am not allowed to apply edits to this PR, so I'll wait for you to do that

BaseMax and others added 2 commits March 16, 2026 15:58
@BaseMax @fingolfin
Update README.md
9da8b83 
Co-authored-by: Max Horn <max@quendi.de>
@BaseMax @fingolfin
Update README.md
133c357 
Co-authored-by: Max Horn <max@quendi.de>
@BaseMax
Copy link
Copy Markdown
Contributor Author

BaseMax commented Mar 16, 2026

Hi Max, Sounds great, applied. Thanks.

@fingolfin fingolfin merged commit e5c32c4 into gap-packages:master Mar 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fingolfin fingolfin fingolfin approved these changes

@james-d-mitchell james-d-mitchell Awaiting requested review from james-d-mitchell

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@BaseMax @james-d-mitchell @fingolfin