Unify python-gardenlinux-lib based feature and cname parsing#115
Unify python-gardenlinux-lib based feature and cname parsing#115NotTheEvilOne wants to merge 1 commit intomainfrom
python-gardenlinux-lib based feature and cname parsing#115Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
NotTheEvilOne
force-pushed
the
feature/python-lib-support
branch
2 times, most recently
from
6423af1 to
794f3bd
Compare
NotTheEvilOne
force-pushed
the
feature/python-lib-support
branch
from
794f3bd to
2fbc117
Compare
NotTheEvilOne
force-pushed
the
feature/python-lib-support
branch
from
2fbc117 to
8b2977a
Compare
|
We should consider how this relates to the following issues and maybe resolve those first, before we proceed here |
NotTheEvilOne
force-pushed
the
feature/python-lib-support
branch
2 times, most recently
from
14a5837 to
12e7f2b
Compare
NotTheEvilOne
force-pushed
the
feature/python-lib-support
branch
from
12e7f2b to
5f11648
Compare
NotTheEvilOne
force-pushed
the
feature/python-lib-support
branch
from
5f11648 to
4ed9d3d
Compare
NotTheEvilOne
force-pushed
the
feature/python-lib-support
branch
2 times, most recently
from
42e4630 to
7cee5d2
Compare
NotTheEvilOne
force-pushed
the
feature/python-lib-support
branch
4 times, most recently
from
b04935b to
4ffdd12
Compare
Signed-off-by: Tobias Wolf <wolf@b1-systems.de> On-behalf-of: SAP <tobias.wolf@sap.com>
NotTheEvilOne
force-pushed
the
feature/python-lib-support
branch
from
4ffdd12 to
741db9b
Compare
| features_platforms="$$(gl-features-parse --feature-dir features --default-arch '$$(DEFAULT_ARCH)' --cname '$*'platforms)" | ||
| features_elements="$$(gl-features-parse --feature-dir features --default-arch '$$(DEFAULT_ARCH)' --cname '$*'elements)" | ||
| features_flags="$$(gl-features-parse --feature-dir features --default-arch '$$(DEFAULT_ARCH)' --cname '$*'flags)" | ||
| BUILDER_CNAME='$*' |
There was a problem hiding this comment.
With the change from .build/%-$(SHORT_COMMIT).tar to .build/%.tar $* would now include the commit. This would break the expected value in this field that is later exported into /etc/os-release. Other tools (e.g. gardenlinux-update) rely on the format of this value so we can not just change this without good reason.
| features_platforms="$$$$(gl-features-parse --feature-dir features --default-arch '$$(DEFAULT_ARCH)' --cname '$$*' platforms)" | ||
| features_elements="$$$$(gl-features-parse --feature-dir features --default-arch '$$(DEFAULT_ARCH)' --cname '$$*' elements)" | ||
| features_flags="$$$$(gl-features-parse --feature-dir features --default-arch '$$(DEFAULT_ARCH)' --cname '$$*' flags)" | ||
| BUILDER_CNAME='$$*' |
|
How does this behave in cases where one builds e.g. If I read the Makefile correctly this would result in internally inconsistent values in the Even if the |
Good catch. While this was already verified for commits it was not checked for versions. Added the additional checks to gardenlinux/python-gardenlinux-lib#306 |
2 participants
What this PR does / why we need it:
Currently
builder/parse_featuresprovides duplicated code and features withpython-gardenlinux-libto parse and return information about GardenLinux features, flavors and canonical names. To unify and ensure code quality this PR replaces it with the CLI utilities ofpython-gardenlinux-lib.Which issue(s) this PR fixes:
Related gardenlinux/python-gardenlinux-lib#129