Narrow destructiveHint usage#253
Merged
cameroncooke merged 3 commits intogetsentry:mainfrom Mar 2, 2026
Merged
Conversation
commit: |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Set destructiveHint to false for tools that mutate state but are not destructive to user data or environment state in the common sense. Keep destructive hints reserved for actually destructive operations while preserving explicit annotation semantics for client UX and approval behavior.
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Collaborator
|
Thanks @saschagordner for the contribution and I agree it was tool hits were too cautious |
Author
|
@cameroncooke |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now my agent asks for permission for tools every session where I don’t think permission should be required, e.g.
session_set_defaults/build_run_sim.That led me to notice the broad usage of
destructiveHint, and I think it should be applied more narrowly.I had Codex audit all tool manifests and their respective implementations and remove
destructiveHintwhere tools are not destructive by MCP semantics (using the Anthropicmcp-builderguidance as the baseline).@cameroncooke What do you think about this?