Skip to content

fix: Remove AGP 7.x R8 workaround#1222

Open
runningcode wants to merge 2 commits into
mainfrom
no/remove-agp7-r8-workaround
Open

fix: Remove AGP 7.x R8 workaround#1222
runningcode wants to merge 2 commits into
mainfrom
no/remove-agp7-r8-workaround

Conversation

@runningcode

@runningcode runningcode commented May 22, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Remove the conditional R8 classpath override that was only needed for AGP 7.x compatibility with compileSdk 34
  • AGP 7.x is no longer in the CI matrix and the default AGP version is 8.10.1, making this dead code
  • Removes the workaround from both build.gradle.kts and the test template in BaseSentryPluginTest.kt

#skip-changelog

🤖 Generated with Claude Code

@0xadam-brown 0xadam-brown left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rbro112 rbro112 removed their request for review June 1, 2026 16:33
runningcode and others added 2 commits June 12, 2026 12:17
AGP 7.x is no longer in the CI matrix and the default AGP version is
8.10.1. The conditional R8 classpath override is dead code.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@romtsn romtsn force-pushed the no/remove-agp7-r8-workaround branch from f5b80a8 to 7fc3951 Compare June 12, 2026 10:17

@romtsn romtsn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it's fine to not test compat with 7.x.x -- checked the usage and there's overall around ~500 AGP 7.x.x users (out of those who opted in for telemetry). We should drop it in the next major and it's fine to accept the risk of breaking something for the small number of users for now, imo (it's like 1.5% of overall).

Image

@runningcode

runningcode commented Jul 2, 2026

Copy link
Copy Markdown
Contributor Author

I'm seeing this in sentry-java but probably not related to this:

WARNING: R8: An error occurred when parsing kotlin metadata. This normally happens when using a newer version of kotlin than the kotlin version released when this version of R8 was created. To find compatible kotlin versions, please see: https://developer.android.com/studio/build/kotlin-d8-r8-versions

https://github.com/getsentry/sentry-java/actions/runs/28527031334/job/84566138543?pr=5670#step:9:508

@runningcode

Copy link
Copy Markdown
Contributor Author

Actually we don't run the release builds against AGP 7.X so this wouldn't affect customers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants