Conversation
|
dc313f3 to
a015008
Compare
7c1c385 to
d951044
Compare
d951044 to
71de725
Compare
71de725 to
6f945b3
Compare
That's just cleaner than having side-effects in TP
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| # When rate-limited, skip the category without polling the buffer. Items remain | ||
| # in the buffer and will be sent once the rate limit expires. No client report is | ||
| # recorded here because items are not discarded — they are retained for later retry. | ||
| # Note: if the buffer overflows while items are held back, the overflow will be | ||
| # reported as :cache_overflow rather than :ratelimit_backoff. |
There was a problem hiding this comment.
Oops, I'm sorry. I think this might not have been 100% clear.
Before adding an item to a specific buffer, the telemetry buffer SHOULD drop rate-limited items to avoid overhead. If doing so, it MUST record client reports.
Telemetry Processor
If a rate limit is active, we recommend SDKs to all the rate limited data, see
Events, transactions, sessions, and/or any other supported payload type, depending on the communicated limits, are to be discarded during the period that the rate limit is in place.
Rate Limiting
Do you think I should change the develop docs accordingly so this is clearer, or do you think it is clear enough?
I could add an extra sentence that clearly specifies: when the buffer applies rate limits, it must drop them and not wait to send. I could also update the develop docs on rate limiting to more clearly point this out. Would that help?
There was a problem hiding this comment.
@philipphofmann thanks for clarification! should we be sending client reports or just completely ignore dropped items as if nothing ever happened? 🙃
This addresses suggestions from #987 (review) specifically:
#skip-changelog