ref(jcache): [Cache Tracing 16] Merge startSpan helpers into shared core method#5205
Merged
adinauer merged 2 commits intofeat/cache-tracingfrom Mar 23, 2026
Merged
Conversation
Replace the separate startSpanForKeys helper with a startSpan(Set, String) overload, unifying the two span creation methods under the same name. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This was referenced Mar 18, 2026
Merged
fix(spring): [Cache Tracing 14] Fix cache hit detection for typed get and fix jcache docs link
#5203
Merged
Member
Author
|
@sentry review |
Member
Author
|
cursor review |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
adinauer
force-pushed
the
ref/cache-tracing-method-specific-ops
branch
from
384cb3e to
0a32614
Compare
This was referenced Mar 18, 2026
Merged
Merged
Merged
lbloder
approved these changes
Mar 20, 2026
| } | ||
| span.setData(OPERATION_ATTRIBUTE, operationName); | ||
| return span; | ||
| return startSpan(operationName, keyString, keyString != null ? Arrays.asList(keyString) : null); |
Collaborator
There was a problem hiding this comment.
(l) Arrays.asList() could potentially be replaced with Collections.singletonList()
Base automatically changed from
ref/cache-tracing-method-specific-ops
to
feat/cache-tracing
March 23, 2026 14:22
Contributor
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. This PR will not appear in the changelog. 🤖 This preview updates automatically when you update the PR. |
Sentry Build Distribution
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Stack (Cache Tracing)
📜 Description
In
SentryJCacheWrapper, thestartSpanandstartSpanForKeyshelpers had duplicated span creation logic. This PR extracts the shared logic into a single core methodstartSpan(String operationName, String description, List<String> cacheKeys), and turns the existingstartSpan(Object key, ...)andstartSpanForKeys(Set<?> keys, ...)into thin convenience wrappers that convert their arguments and delegate.Also includes Spotless formatting fixes for the Spring wrapper
startSpanmethods from the previous PR.💡 Motivation and Context
Reduces code duplication in the JCache wrapper's span helper methods.
💚 How did you test it?
SentryJCacheWrapperTesttests pass📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps
#skip-changelog