feat: Adopt bindTracingChannelToSpan across runtimes#21642
Open
logaretm wants to merge 2 commits into
Open
Conversation
logaretm
force-pushed
the
awad/bind-tracing-channel
branch
from
8c4ca47 to
61a560f
Compare
logaretm
force-pushed
the
awad/adopt-bind-tracing-channel
branch
from
e189fda to
3f71785
Compare
Contributor
size-limit report 📦
|
logaretm
force-pushed
the
awad/adopt-bind-tracing-channel
branch
2 times, most recently
from
8ec64f0 to
7a09a2e
Compare
mydea
reviewed
Jun 19, 2026
| expect.objectContaining({ | ||
| handled: false, | ||
| type: 'auto.http.nitro.onTraceError', | ||
| type: 'auto.diagnostic_channels.bind_span', |
Member
There was a problem hiding this comment.
this is no good, this should be somewhat similar to what it was before 😬
Member
Author
There was a problem hiding this comment.
okay I can add an option for error mechanism to preserve this
logaretm
force-pushed
the
awad/bind-tracing-channel
branch
from
2fbdda3 to
3cb7959
Compare
logaretm
force-pushed
the
awad/adopt-bind-tracing-channel
branch
from
7a09a2e to
a11202f
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
logaretm
force-pushed
the
awad/bind-tracing-channel
branch
from
3cb7959 to
e34e28a
Compare
logaretm
force-pushed
the
awad/adopt-bind-tracing-channel
branch
from
d452bdb to
2d8060e
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 3 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 2d8060e. Configure here.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 2d8060e. Configure here.
Migrate the Nitro HTTP/storage channels and the node/deno redis diagnostics_channel subscribers off the `@sentry/opentelemetry` `tracingChannel` helper onto `bindTracingChannelToSpan` from `@sentry/server-utils`, using the `auto` lifecycle. - Add `beforeSpanEnd(span, data)` to enrich the span on the canonical terminal event (sync `end` / async `asyncEnd`) right before it ends. - Add `captureError` (default `true`) to gate exception capture; the span error status is always set. Redis opts out (`captureError: false`) since command failures are captured at the boundary that owns them. - Unify the error mechanism to `auto.diagnostic_channels.bind_span`. - Create channel spans with `startInactiveSpan`; the binding activates the span as the async context, so parenting is preserved. - node and deno redis now pass the native `node:diagnostics_channel` `tracingChannel` directly; deno's bespoke factory is removed. BREAKING: remove the `@sentry/opentelemetry/tracing-channel` subpath export (shipped in 10.58.0); use `bindTracingChannelToSpan` instead.
logaretm
force-pushed
the
awad/adopt-bind-tracing-channel
branch
from
766b254 to
05cfa5b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adopts
bindTracingChannelToSpanutility across our packages, and drops thetracingChannelhelper we had.The
tracingChanneldrop isn't a breaking change imo, its an internal export used by us exclusively.