Skip to content

chore(django): Remove transaction-based tracing - #7190

Draft
sentrivana wants to merge 2 commits into
major/3.0from
ivana/major/remove-transactions-django
Draft

chore(django): Remove transaction-based tracing#7190
sentrivana wants to merge 2 commits into
major/3.0from
ivana/major/remove-transactions-django

Conversation

@sentrivana

Copy link
Copy Markdown
Contributor

Closes PY-2689
Closes #7085

@linear-code

linear-code Bot commented Aug 13, 2026

Copy link
Copy Markdown

PY-2689

@github-actions

Copy link
Copy Markdown
Contributor

Codecov Results 📊

99531 passed | ❌ 1950 failed | ⏭️ 5317 skipped | Total: 106798 | Pass Rate: 93.2% | Execution Time: 337m 51s

📊 Comparison with Base Branch

Metric Change
Total Tests 📉 -12424
Passed Tests 📉 -12932
Failed Tests 📈 +1950
Skipped Tests 📉 -1442

➕ New Tests (18)

View new tests
  • test_set_db_data_custom_backend
    • File: tests.integrations.django.test_basic
    • Status: ❌ Failing
  • test_set_db_data_custom_backend
    • File: tests.integrations.django.test_basic
    • Status: ❌ Failing
  • test_set_db_data_custom_backend
    • File: tests.integrations.django.test_basic
    • Status: ❌ Failing
  • test_set_db_data_custom_backend
    • File: tests.integrations.django.test_basic
    • Status: ❌ Failing
  • test_set_db_data_custom_backend
    • File: tests.integrations.django.test_basic
    • Status: ❌ Failing
  • test_set_db_data_custom_backend
    • File: tests.integrations.django.test_basic
    • Status: ❌ Failing
  • test_set_db_data_custom_backend
    • File: tests.integrations.django.test_basic
    • Status: ❌ Failing
  • test_set_db_data_custom_backend
    • File: tests.integrations.django.test_basic
    • Status: ❌ Failing
  • test_set_db_data_custom_backend
    • File: tests.integrations.django.test_basic
    • Status: ❌ Failing
  • test_set_db_data_custom_backend
    • File: tests.integrations.django.test_basic
    • Status: ❌ Failing
  • test_set_db_data_custom_backend
    • File: tests.integrations.django.test_basic
    • Status: ❌ Failing
  • test_set_db_data_custom_backend
    • File: tests.integrations.django.test_basic
    • Status: ❌ Failing
  • test_set_db_data_custom_backend
    • File: tests.integrations.django.test_basic
    • Status: ❌ Failing
  • test_set_db_data_custom_backend
    • File: tests.integrations.django.test_basic
    • Status: ❌ Failing
  • test_set_db_data_custom_backend
    • File: tests.integrations.django.test_basic
    • Status: ❌ Failing
  • test_set_db_data_custom_backend
    • File: tests.integrations.django.test_basic
    • Status: ❌ Failing
  • test_set_db_data_custom_backend
    • File: tests.integrations.django.test_basic
    • Status: ❌ Failing
  • test_set_db_data_custom_backend
    • File: tests.integrations.django.test_basic
    • Status: ❌ Failing

❌ Failed Tests

test_set_db_data_custom_backend

File: tests.integrations.django.test_basic
Suite: py3.10-django-v3.2.25
Error: AttributeError: 'Span' object has no attribute 'set_attribute'

Stack Trace
tests/integrations/django/test_basic.py:872: in test_set_db_data_custom_backend
    _set_db_data(Span(), DummyBackend())
sentry_sdk/integrations/django/__init__.py:758: in _set_db_data
    span.set_attribute(SPANDATA.DB_SYSTEM_NAME, vendor)
E   AttributeError: 'Span' object has no attribute 'set_attribute'

test_set_db_data_custom_backend

File: tests.integrations.django.test_basic
Suite: py3.10-django-v5.2.17
Error: AttributeError: 'Span' object has no attribute 'set_attribute'

Stack Trace
tests/integrations/django/test_basic.py:872: in test_set_db_data_custom_backend
    _set_db_data(Span(), DummyBackend())
sentry_sdk/integrations/django/__init__.py:758: in _set_db_data
    span.set_attribute(SPANDATA.DB_SYSTEM_NAME, vendor)
E   AttributeError: 'Span' object has no attribute 'set_attribute'

test_set_db_data_custom_backend

File: tests.integrations.django.test_basic
Suite: py3.11-django-v4.2.30
Error: AttributeError: 'Span' object has no attribute 'set_attribute'

Stack Trace
tests/integrations/django/test_basic.py:872: in test_set_db_data_custom_backend
    _set_db_data(Span(), DummyBackend())
sentry_sdk/integrations/django/__init__.py:758: in _set_db_data
    span.set_attribute(SPANDATA.DB_SYSTEM_NAME, vendor)
    ^^^^^^^^^^^^^^^^^^
E   AttributeError: 'Span' object has no attribute 'set_attribute'

test_set_db_data_custom_backend

File: tests.integrations.django.test_basic
Suite: py3.12-django-v4.2.30
Error: AttributeError: 'Span' object has no attribute 'set_attribute'

Stack Trace
tests/integrations/django/test_basic.py:872: in test_set_db_data_custom_backend
    _set_db_data(Span(), DummyBackend())
sentry_sdk/integrations/django/__init__.py:758: in _set_db_data
    span.set_attribute(SPANDATA.DB_SYSTEM_NAME, vendor)
    ^^^^^^^^^^^^^^^^^^
E   AttributeError: 'Span' object has no attribute 'set_attribute'

test_set_db_data_custom_backend

File: tests.integrations.django.test_basic
Suite: py3.12-django-v6.1
Error: AttributeError: 'Span' object has no attribute 'set_attribute'

Stack Trace
tests/integrations/django/test_basic.py:872: in test_set_db_data_custom_backend
    _set_db_data(Span(), DummyBackend())
sentry_sdk/integrations/django/__init__.py:758: in _set_db_data
    span.set_attribute(SPANDATA.DB_SYSTEM_NAME, vendor)
    ^^^^^^^^^^^^^^^^^^
E   AttributeError: 'Span' object has no attribute 'set_attribute'

test_set_db_data_custom_backend

File: tests.integrations.django.test_basic
Suite: py3.13-django-v5.2.17
Error: AttributeError: 'Span' object has no attribute 'set_attribute'

Stack Trace
tests/integrations/django/test_basic.py:872: in test_set_db_data_custom_backend
    _set_db_data(Span(), DummyBackend())
sentry_sdk/integrations/django/__init__.py:758: in _set_db_data
    span.set_attribute(SPANDATA.DB_SYSTEM_NAME, vendor)
    ^^^^^^^^^^^^^^^^^^
E   AttributeError: 'Span' object has no attribute 'set_attribute'

test_set_db_data_custom_backend

File: tests.integrations.django.test_basic
Suite: py3.13-django-v6.1
Error: AttributeError: 'Span' object has no attribute 'set_attribute'

Stack Trace
tests/integrations/django/test_basic.py:872: in test_set_db_data_custom_backend
    _set_db_data(Span(), DummyBackend())
sentry_sdk/integrations/django/__init__.py:758: in _set_db_data
    span.set_attribute(SPANDATA.DB_SYSTEM_NAME, vendor)
    ^^^^^^^^^^^^^^^^^^
E   AttributeError: 'Span' object has no attribute 'set_attribute'

test_set_db_data_custom_backend

File: tests.integrations.django.test_basic
Suite: py3.14-django-v5.2.17
Error: AttributeError: 'Span' object has no attribute 'set_attribute'

Stack Trace
tests/integrations/django/test_basic.py:872: in test_set_db_data_custom_backend
    _set_db_data(Span(), DummyBackend())
sentry_sdk/integrations/django/__init__.py:758: in _set_db_data
    span.set_attribute(SPANDATA.DB_SYSTEM_NAME, vendor)
    ^^^^^^^^^^^^^^^^^^
E   AttributeError: 'Span' object has no attribute 'set_attribute'

test_set_db_data_custom_backend

File: tests.integrations.django.test_basic
Suite: py3.14-django-v6.1
Error: AttributeError: 'Span' object has no attribute 'set_attribute'

Stack Trace
tests/integrations/django/test_basic.py:872: in test_set_db_data_custom_backend
    _set_db_data(Span(), DummyBackend())
sentry_sdk/integrations/django/__init__.py:758: in _set_db_data
    span.set_attribute(SPANDATA.DB_SYSTEM_NAME, vendor)
    ^^^^^^^^^^^^^^^^^^
E   AttributeError: 'Span' object has no attribute 'set_attribute'

test_set_db_data_custom_backend

File: tests.integrations.django.test_basic
Suite: py3.14t-django-v5.2.17
Error: AttributeError: 'Span' object has no attribute 'set_attribute'

Stack Trace
tests/integrations/django/test_basic.py:872: in test_set_db_data_custom_backend
    _set_db_data(Span(), DummyBackend())
sentry_sdk/integrations/django/__init__.py:758: in _set_db_data
    span.set_attribute(SPANDATA.DB_SYSTEM_NAME, vendor)
    ^^^^^^^^^^^^^^^^^^
E   AttributeError: 'Span' object has no attribute 'set_attribute'

test_set_db_data_custom_backend

File: tests.integrations.django.test_basic
Suite: py3.14t-django-v6.1
Error: AttributeError: 'Span' object has no attribute 'set_attribute'

Stack Trace
tests/integrations/django/test_basic.py:872: in test_set_db_data_custom_backend
    _set_db_data(Span(), DummyBackend())
sentry_sdk/integrations/django/__init__.py:758: in _set_db_data
    span.set_attribute(SPANDATA.DB_SYSTEM_NAME, vendor)
    ^^^^^^^^^^^^^^^^^^
E   AttributeError: 'Span' object has no attribute 'set_attribute'

test_set_db_data_custom_backend

File: tests.integrations.django.test_basic
Suite: py3.7-django-v2.0.13
Error: AttributeError: 'Span' object has no attribute 'set_attribute'

Stack Trace
tests/integrations/django/test_basic.py:872: in test_set_db_data_custom_backend
    _set_db_data(Span(), DummyBackend())
sentry_sdk/integrations/django/__init__.py:758: in _set_db_data
    span.set_attribute(SPANDATA.DB_SYSTEM_NAME, vendor)
E   AttributeError: 'Span' object has no attribute 'set_attribute'

test_set_db_data_custom_backend

File: tests.integrations.django.test_basic
Suite: py3.7-django-v2.2.28
Error: AttributeError: 'Span' object has no attribute 'set_attribute'

Stack Trace
tests/integrations/django/test_basic.py:872: in test_set_db_data_custom_backend
    _set_db_data(Span(), DummyBackend())
sentry_sdk/integrations/django/__init__.py:758: in _set_db_data
    span.set_attribute(SPANDATA.DB_SYSTEM_NAME, vendor)
E   AttributeError: 'Span' object has no attribute 'set_attribute'

test_set_db_data_custom_backend

File: tests.integrations.django.test_basic
Suite: py3.7-django-v3.2.25
Error: AttributeError: 'Span' object has no attribute 'set_attribute'

Stack Trace
tests/integrations/django/test_basic.py:872: in test_set_db_data_custom_backend
    _set_db_data(Span(), DummyBackend())
sentry_sdk/integrations/django/__init__.py:758: in _set_db_data
    span.set_attribute(SPANDATA.DB_SYSTEM_NAME, vendor)
E   AttributeError: 'Span' object has no attribute 'set_attribute'

test_set_db_data_custom_backend

File: tests.integrations.django.test_basic
Suite: py3.8-django-v2.2.28
Error: AttributeError: 'Span' object has no attribute 'set_attribute'

Stack Trace
tests/integrations/django/test_basic.py:872: in test_set_db_data_custom_backend
    _set_db_data(Span(), DummyBackend())
sentry_sdk/integrations/django/__init__.py:758: in _set_db_data
    span.set_attribute(SPANDATA.DB_SYSTEM_NAME, vendor)
E   AttributeError: 'Span' object has no attribute 'set_attribute'

test_set_db_data_custom_backend

File: tests.integrations.django.test_basic
Suite: py3.8-django-v4.2.30
Error: AttributeError: 'Span' object has no attribute 'set_attribute'

Stack Trace
tests/integrations/django/test_basic.py:872: in test_set_db_data_custom_backend
    _set_db_data(Span(), DummyBackend())
sentry_sdk/integrations/django/__init__.py:758: in _set_db_data
    span.set_attribute(SPANDATA.DB_SYSTEM_NAME, vendor)
E   AttributeError: 'Span' object has no attribute 'set_attribute'

test_set_db_data_custom_backend

File: tests.integrations.django.test_basic
Suite: py3.9-django-v2.2.28
Error: AttributeError: 'Span' object has no attribute 'set_attribute'

Stack Trace
tests/integrations/django/test_basic.py:872: in test_set_db_data_custom_backend
    _set_db_data(Span(), DummyBackend())
sentry_sdk/integrations/django/__init__.py:758: in _set_db_data
    span.set_attribute(SPANDATA.DB_SYSTEM_NAME, vendor)
E   AttributeError: 'Span' object has no attribute 'set_attribute'

test_set_db_data_custom_backend

File: tests.integrations.django.test_basic
Suite: py3.9-django-v3.2.25
Error: AttributeError: 'Span' object has no attribute 'set_attribute'

Stack Trace
tests/integrations/django/test_basic.py:872: in test_set_db_data_custom_backend
    _set_db_data(Span(), DummyBackend())
sentry_sdk/integrations/django/__init__.py:758: in _set_db_data
    span.set_attribute(SPANDATA.DB_SYSTEM_NAME, vendor)
E   AttributeError: 'Span' object has no attribute 'set_attribute'

❌ Patch coverage is 40.00%. Project has 2593 uncovered lines.
❌ Project coverage is 89.11%. Comparing base (base) to head (head).

Files with missing lines (6)
File Patch % Lines
sentry_sdk/integrations/django/caching.py 0.00% ⚠️ 36 Missing
sentry_sdk/integrations/django/init.py 30.00% ⚠️ 21 Missing and 2 partials
sentry_sdk/integrations/django/templates.py 75.00% ⚠️ 2 Missing and 2 partials
sentry_sdk/integrations/django/views.py 83.33% ⚠️ 2 Missing and 2 partials
sentry_sdk/integrations/django/asgi.py 87.50% ⚠️ 1 Missing and 1 partials
sentry_sdk/integrations/django/middleware.py 66.67% ⚠️ 1 Missing and 1 partials
Coverage diff
@@            Coverage Diff             @@
##          main       #PR       +/-##
==========================================
- Coverage    90.23%    89.11%    -1.12%
==========================================
  Files          193       185        -8
  Lines        25361     23807     -1554
  Branches      9302      8740      -562
==========================================
+ Hits         22883     21214     -1669
- Misses        2478      2593      +115
- Partials      1432      1392       -40

Generated by Codecov Action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant