Skip to content

Fix command injection vulnerability in iOS workflow#2598

Merged
bitsandfoxes merged 1 commit intomainfrom
fix/eng-7130-ios-workflow-injection
Mar 23, 2026
Merged

Fix command injection vulnerability in iOS workflow#2598
bitsandfoxes merged 1 commit intomainfrom
fix/eng-7130-ios-workflow-injection

Conversation

@fix-it-felix-sentry
Copy link
Contributor

Summary

This PR fixes a command injection vulnerability in the iOS workflow by moving the ios-version input from direct interpolation in the run: script to an environment variable.

Changes

  • Moved ${{ inputs.ios-version }} from the run: script to an env: block as SENTRY_IOS_VERSION
  • Removed the direct assignment in the PowerShell script (the env var is automatically available as $env:SENTRY_IOS_VERSION)

Security Impact

Using GitHub context data directly in run: scripts can allow attackers to inject malicious code if they control the input value. By using an intermediate environment variable, the input is safely escaped and cannot be used for code injection.

References

Move ios-version input to environment variable to prevent potential
command injection attacks. Using GitHub context data directly in run
scripts can allow attackers to inject malicious code if they control
the input value.

Fixes: https://linear.app/getsentry/issue/VULN-1334
Fixes: https://linear.app/getsentry/issue/ENG-7130

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
@linear-code
Copy link

linear-code bot commented Mar 22, 2026

@github-actions
Copy link
Contributor

Semver Impact of This PR

None (no version bump detected)

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).


Internal Changes 🔧

  • (deps) Update Java SDK to v8.36.0 by github-actions in #2591

Other

  • Fix command injection vulnerability in iOS workflow by fix-it-felix-sentry[bot] in #2598

🤖 This preview updates automatically when you update the PR.

@github-actions
Copy link
Contributor

Fails
🚫 Please consider adding a changelog entry for the next release.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

### Fixes

- Fix command injection vulnerability in iOS workflow ([#2598](https://github.com/getsentry/sentry-unity/pull/2598))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description or adding a skip-changelog label.

Generated by 🚫 dangerJS against 858c4f6

@bitsandfoxes bitsandfoxes merged commit 89e9c67 into main Mar 23, 2026
67 of 70 checks passed
@bitsandfoxes bitsandfoxes deleted the fix/eng-7130-ios-workflow-injection branch March 23, 2026 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant