Fix command injection vulnerability in iOS workflow#2598
Merged
bitsandfoxes merged 1 commit intomainfrom Mar 23, 2026
Merged
Conversation
Move ios-version input to environment variable to prevent potential command injection attacks. Using GitHub context data directly in run scripts can allow attackers to inject malicious code if they control the input value. Fixes: https://linear.app/getsentry/issue/VULN-1334 Fixes: https://linear.app/getsentry/issue/ENG-7130 Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Contributor
Semver Impact of This PR⚪ None (no version bump detected) 📋 Changelog PreviewThis is how your changes will appear in the changelog. Internal Changes 🔧
Other
🤖 This preview updates automatically when you update the PR. |
Contributor
Instructions and example for changelogPlease add an entry to Example: ## Unreleased
### Fixes
- Fix command injection vulnerability in iOS workflow ([#2598](https://github.com/getsentry/sentry-unity/pull/2598))If none of the above apply, you can opt out of this check by adding |
bitsandfoxes
approved these changes
Mar 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a command injection vulnerability in the iOS workflow by moving the
ios-versioninput from direct interpolation in therun:script to an environment variable.Changes
${{ inputs.ios-version }}from therun:script to anenv:block asSENTRY_IOS_VERSION$env:SENTRY_IOS_VERSION)Security Impact
Using GitHub context data directly in
run:scripts can allow attackers to inject malicious code if they control the input value. By using an intermediate environment variable, the input is safely escaped and cannot be used for code injection.References