-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
No issues matched links #104824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
No issues matched links #104824
Conversation
Co-authored-by: sasha.blumenfeld <[email protected]>
|
Cursor Agent can help with this pull request. Just |
Co-authored-by: sasha.blumenfeld <[email protected]>
| ), | ||
| } | ||
| )} | ||
| </div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Logs link shown without checking feature flag
The new logs link is displayed unconditionally to all users, but the logs feature (explore/logs) is gated behind the ourlogs-enabled feature flag throughout the codebase. Other components like the command palette check organization.features.includes('ourlogs-enabled') before showing logs links. Users without this feature enabled will see a suggestion to explore logs but may encounter an error or inaccessible page when clicking the link. The organization from useOrganization() is already available in this component and could be used to conditionally render this section.

Updates the
NoIssuesMatchedcomponent to improve user guidance when no issues are found.This PR:
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
Slack Thread