feat(preprod): Add odiff server wrapper and Dockerfile binary install#109380
feat(preprod): Add odiff server wrapper and Dockerfile binary install#109380NicoHinderling wants to merge 10 commits intomasterfrom
Conversation
github-actions
bot
added
the
Scope: Backend
self-hosted/Dockerfile
Outdated
| && apt-get update \ | ||
| && apt-get install -y --no-install-recommends $buildDeps \ | ||
| && uv sync --frozen --quiet --no-install-project \ | ||
| && case "$(dpkg --print-architecture)" in \ |
There was a problem hiding this comment.
we should move this into its own layer as it's separate from uv.lock, otherwise we'll do this every time a python dep changes
pretty sure this is all possible with docker primitives + multistage (to handle the docker arch for multiplat builds) at this point too; let me just commit this for you
There was a problem hiding this comment.
Thank you!
NicoHinderling
force-pushed
the
create-compare-task-v1-part1
branch
from
cfd6b61 to
4b1becf
Compare
This stack of pull requests is managed by Graphite. Learn more about stacking. |
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
NicoHinderling
force-pushed
the
create-compare-task-v1-part1
branch
from
10e12d3 to
5b2dabe
Compare
NicoHinderling
force-pushed
the
create-compare-task-v1-part1
branch
from
5b2dabe to
01b72d2
Compare
NicoHinderling
force-pushed
the
create-compare-task-v1-part1
branch
from
ca48cee to
12f0802
Compare
NicoHinderling
force-pushed
the
create-compare-task-v1-part1
branch
from
12f0802 to
740cd3e
Compare
NicoHinderling
force-pushed
the
create-compare-task-v1-part1
branch
from
740cd3e to
cd0f0ad
Compare
Add the odiff subprocess wrapper (OdiffServer) for image comparison, the DiffResult type, and install the odiff binary in the self-hosted Dockerfile.
NicoHinderling
force-pushed
the
create-compare-task-v1-part1
branch
from
cd0f0ad to
89193fa
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable autofix in the Cursor dashboard.
github-actions
bot
added
the
Scope: Frontend
|
🚨 Warning: This pull request contains Frontend and Backend changes! It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently. Have questions? Please ask in the |
2 participants
Summary
OdiffServersubprocess wrapper that communicates with odiff via JSON-over-stdin/stdout protocolDiffResultdataclass for structured diff outputStack: 1/3 — next: image comparison library