fix(seer): Prevent text selection loss during mouse drag in explorer …#109395
Closed
isaacwang-sentry wants to merge 1 commit intomasterfrom
Closed
fix(seer): Prevent text selection loss during mouse drag in explorer …#109395isaacwang-sentry wants to merge 1 commit intomasterfrom
isaacwang-sentry wants to merge 1 commit intomasterfrom
Conversation
…panel When users click and drag to select text across block boundaries in the Seer Explorer panel, onMouseEnter handlers fire setFocusedBlockIndex(), causing React re-renders that destroy the active selection. Track mouse-button-down state via a ref and suppress focus changes during drag operations. Co-Authored-By: Claude <noreply@anthropic.com>
github-actions
bot
added
the
Scope: Frontend
Contributor
|
This issue has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you remove the label "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When users click and drag to select text across block boundaries in the Seer Explorer panel, onMouseEnter handlers fire setFocusedBlockIndex(), causing React re-renders that destroy the active selection. Track mouse-button-down state via a ref and suppress focus changes during drag operations.
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.