chore(iswf): Updates deletion and remaining task decorators to taskbroker retries

[GabeVillalobos]

Continuing the work of #114937, this PR removes more of the old @retry decorators from tasks, updating them to their closest equivalent in Taskbroker.

[cursor]

Dead RetryTask class after retry migration

Low Severity

The RetryTask exception class is now unused dead code. It was previously referenced in Retry(on=(RetryTask,)), but this change replaced that with Retry(on=(Exception,)). The class definition remains, and the TODO comment on line 145 — "raise RetryTask when appropriate" — is now stale and misleading, since with on=(Exception,) there's no reason to raise a specific RetryTask subclass for retry purposes.

Additional Locations (1)

• src/sentry/deletions/tasks/nodestore.py#L144-L145

 

^{Reviewed by Cursor Bugbot for commit 2a171e2. Configure here.}

[markstory]

The module local RetryTask does look unused.

[GabeVillalobos]

I'll remove that in a follow up 😁

[markstory]

The module local RetryTask does look unused.

[cursor]

Cursor Bugbot has reviewed your changes and found 1 potential issue.

There are 2 total unresolved issues (including 1 from previous review).

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit 799d45c. Configure here.}

[cursor]

Retry only on DoesNotExist silently discards all other errors

Medium Severity

The Retry(on=(Commit.DoesNotExist,)) combined with silenced_exceptions=(Commit.DoesNotExist,) means that Commit.DoesNotExist is both retried AND silenced from Sentry. If all retries are exhausted and the commit still doesn't exist, the final failure will never be reported to Sentry, making permanent failures completely invisible. The old on_silent in the @retry decorator only suppressed reporting during retry attempts — the final RetryTaskError after exhaustion could still surface. Now there's no visibility into cases where a commit permanently doesn't exist after all retries.

 

^{Reviewed by Cursor Bugbot for commit 799d45c. Configure here.}