feat(autofix): Add high-level autofix settings update helper#115037
Merged
feat(autofix): Add high-level autofix settings update helper#115037
Conversation
github-actions
Bot
added
the
Scope: Backend
srest2021
changed the title
JoshFerge
reviewed
May 7, 2026
JoshFerge
reviewed
May 7, 2026
JoshFerge
approved these changes
May 7, 2026
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
chromy
approved these changes
May 7, 2026
Contributor
chromy
left a comment
chromy
left a comment
There was a problem hiding this comment.
lgtm % a few comments, thank you!
| project.update_option(key, value) | ||
|
|
||
| with transaction.atomic(using=router.db_for_write(ProjectOption)): | ||
| list(Project.objects.select_for_update().filter(id=project.id)) |
Contributor
There was a problem hiding this comment.
What is the purpose of the list(Project.objects.select_for_update().filter(id=project.id)) line?
Member
Author
There was a problem hiding this comment.
This line is locking the project row to make sure we are serializing concurrent writes and avoiding race conditions. So for example if the endpoint gets hit for the same project at the same time we want to make sure we execute one update before the other.
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 372f4a1. Configure here.
constantinius
pushed a commit
that referenced
this pull request
May 8, 2026
Relates to CW-1285 Tldr, add an unused helper and prep stuff for #114899. Adds `update_seer_project_settings`, a helper that translates high-level Seer settings (agent, stopping point, scanner automation) into the underlying project options. This centralizes the write logic so the upcoming bulk and single-project settings endpoints can share it instead of duplicating option-level writes. - **agent=seer**: clears required handoff options (point, target, integration_id) - **agent=cursor/claude**: sets handoff config, requires an integration ID - **stoppingPoint (non-off)**: sets tuning to MEDIUM and stores the stopping point value - **stoppingPoint=off**: sets tuning to OFF; leaves stopping point and auto_create_pr alone so that reenabling tuning restores the prior state - **stoppingPoint=open_pr**: sets auto_create_pr=True; any other stopping point clears it. Safe to set unconditionally since [auto_create_pr is only read when all other handoff options are non-null.](https://github.com/getsentry/sentry/blob/d254733b163432ca88ae796c05d415f97064cbbc/src/sentry/seer/autofix/utils.py#L622) - **stoppingPoint omitted**: tuning and auto_create_pr are left untouched - Options set to their registered default are deleted rather than stored
This was referenced May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to CW-1285
Tldr, add an unused helper and prep stuff for #114899.
Adds
update_seer_project_settings, a helper that translates high-level Seer settings (agent, stopping point, scanner automation) into the underlying project options. This centralizes the write logic so the upcoming bulk and single-project settings endpoints can share it instead of duplicating option-level writes.