feat(avatars): Replace avatar chooser radios with an action menu#119139
Draft
cvxluo wants to merge 1 commit into
Draft
feat(avatars): Replace avatar chooser radios with an action menu#119139cvxluo wants to merge 1 commit into
cvxluo wants to merge 1 commit into
Conversation
github-actions
Bot
added
the
Scope: Frontend
Contributor
📊 Type Coverage Diff
🔍 2 new type safety issues introducedType assertions (
This is informational only and does not block the PR. |
…ding Behind organizations:sentry-app-branding-v2, replace the sentry app details page's two avatar chooser panels with an Identity section at the top of the page: name and author become auto-save rows (the org-settings pattern), and the logo/small icon rows preview the avatar and save immediately from a Change menu, cropping uploads in a modal and offering an undo toast when switching sources. Name and author leave the explicit Save Changes form; the backend supports partial PUTs and never regenerates the slug on rename. With the flag off the page renders exactly as before. Also fix the query-cache update after avatar saves, which destructured a field the avatar endpoint never returns and silently did nothing. Co-authored-by: Claude <noreply@anthropic.com>
cvxluo
force-pushed
the
cvxluo/replace-avatar-chooser-radios-with-an-action-menu
branch
from
9e5294a to
e1bd682
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the avatar chooser's radio group, per-panel save button, and hovercard cropper with a single Change menu and a modal crop dialog. Choices save immediately on selection, with an undo toast when switching between avatar sources. Cropping happens in a modal with a single confirm step instead of the cramped hovercard, unifying the two previous save models.
The chooser now renders as a settings field row instead of its own panel, and each settings page embeds it in its existing field group: next to the display name for organizations, in the account details group for users, in the team settings group for teams, and in a new Branding panel that unifies the logo and small icon rows for sentry apps.
Also fix two call-site issues surfaced by the stricter onSave typing: the sentry app page's query-cache update destructured a field the avatar endpoint never returns, and the doc integration chooser in gsAdmin rendered no preview at all.
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.