Skip to content

feat(dashboards): put in backend validation for heat map request fields#119145

Open
nikkikapadia wants to merge 4 commits into
masterfrom
nikki/tighten-heatmaps-validation
Open

feat(dashboards): put in backend validation for heat map request fields#119145
nikkikapadia wants to merge 4 commits into
masterfrom
nikki/tighten-heatmaps-validation

Conversation

@nikkikapadia

Copy link
Copy Markdown
Member

Closes DAIN-1719

Just adds the validation we have for heatmaps in the frontend to the backend as well. This is only for dashboards right now, i can add in the saved queries one in another PR.

basically we are following the following conditions:

  • heat maps for trace metrics only (this was already previously implemented)
  • no equations
  • singular queries only
  • one aggregate
  • must use distribution metrics
  • no group-bys
  • no thresholds

@linear-code

linear-code Bot commented Jul 7, 2026

Copy link
Copy Markdown

DAIN-1719

@github-actions github-actions Bot added the Scope: Backend Automatically applied to PRs that change backend components label Jul 7, 2026
@nikkikapadia nikkikapadia changed the title Nikki/tighten heatmaps validation feat(dashboards): put in backend validation for heat map request fields Jul 7, 2026

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 2 potential issues.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 81dd37d. Configure here.

Comment thread src/sentry/api/serializers/rest_framework/dashboard.py
Comment thread src/sentry/api/serializers/rest_framework/dashboard.py
@nikkikapadia nikkikapadia marked this pull request as ready for review July 7, 2026 20:24
@nikkikapadia nikkikapadia requested a review from a team as a code owner July 7, 2026 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant