ref: Graduate organizations:on-demand-metrics-ui to a plan feature#119152
Draft
cvxluo wants to merge 2 commits into
Draft
ref: Graduate organizations:on-demand-metrics-ui to a plan feature#119152cvxluo wants to merge 2 commits into
organizations:on-demand-metrics-ui to a plan feature#119152cvxluo wants to merge 2 commits into
Conversation
Remove the graduated on-demand-metrics-ui feature flag registration. The flag was enabled at 100% rollout in the automator since 2023-11-17 and its last code reference is removed in #119151. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01G1DLs4ea5m1WccYABmGArV
github-actions
Bot
added
the
Scope: Backend
Re-register the graduated flag as INTERNAL (api_expose) in permanent.py so it is provided by subscription plans via getsentry's SubscriptionPlanFeatureHandler, instead of the flagpole rollout flag removed from temporary.py. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01G1DLs4ea5m1WccYABmGArV
cvxluo
changed the title
organizations:on-demand-metrics-ui registrationorganizations:on-demand-metrics-ui to a plan feature
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Graduate
organizations:on-demand-metrics-ui: move its registration fromtemporary.py(FLAGPOLE) topermanent.py(INTERNAL,api_expose=True, self-hosted defaultFalse), so it is provided by subscription plans via getsentry'sSubscriptionPlanFeatureHandlerinstead of a flagpole rollout flag.No frontend change: the UI keeps checking
organization.features.includes('on-demand-metrics-ui'); the value now comes from the plan. Current audience (am2 business/enterprise) is preserved.Companion PRs — deploy in this order: getsentry/getsentry#20970 (adds the plan handler; must deploy first) → this PR (flips to INTERNAL) → getsentry/sentry-options-automator#8556 (removes the flagpole config).