Update reflow-scan text to improve clarity and reference WCAG 2.2#231
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the reflow-scan plugin’s user-facing copy (and related test expectations) to better describe the reflow finding and to reference WCAG 2.2.
Changes:
- Revised
problemShort,solutionShort, andsolutionLongtext for reflow findings to be clearer and more action-oriented. - Updated the WCAG “Understanding Reflow” link from WCAG 2.1 to WCAG 2.2.
- Updated test expectations to match the new strings.
Show a summary per file
| File | Description |
|---|---|
.github/scanner-plugins/reflow-scan/index.ts |
Updates reflow-scan finding copy and WCAG reference URL. |
tests/site-with-errors.test.ts |
Updates expected strings/titles to match the revised reflow-scan copy. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 2/2 changed files
- Comments generated: 2
JoyceZhu
reviewed
Jun 17, 2026
| // Check for horizontal scrolling at 320 viewport | ||
| try { | ||
| await page.setViewportSize({ width: 320, height: 256 }) | ||
| await page.setViewportSize({width: 320, height: 256}) |
Contributor
There was a problem hiding this comment.
did Prettier automatically do this?
Contributor
Author
There was a problem hiding this comment.
Yes, Prettier auto-formatted on save
Contributor
|
Let's also bump the patch version up here since we've changed the plugin copy a decent amount. (Whenever we add support for marking filings as Best Practices/Needs Human Review, we can upgrade the minor version) |
JoyceZhu
reviewed
Jun 17, 2026
Contributor
|
suggested a couple wording/typo adjustments from the original request. |
Co-authored-by: Joyce Zhu <joycezhu@github.com>
JoyceZhu
approved these changes
Jun 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #230
Updates the reflow-scan plugin text to improve clarity:
problemShortto better describe the issueproblemUrlto reference WCAG 2.2 instead of 2.1solutionShortto use more descriptive guidancesolutionLongwith clearer violation explanation