chore(skills): pass skillcheck validation across the collection#1942
Open
fhwvtqdc2q-svg wants to merge 1 commit into
Open
chore(skills): pass skillcheck validation across the collection#1942fhwvtqdc2q-svg wants to merge 1 commit into
fhwvtqdc2q-svg wants to merge 1 commit into
Conversation
github-actions
Bot
added
branched-main
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
main, but PRs should target staged.
The main branch is auto-published from staged and should not receive direct PRs.
Please close this PR and re-open it against the staged branch.
You can change the base branch using the Edit button at the top of this PR,
or run: gh pr edit 1942 --base staged
Contributor
|
🔴 Contributor Reputation Check: HIGH risk
Maintainers: please review this contributor before merging. |
github-actions
Bot
added
the
needs-review:HIGH
chore(skills): pass skillcheck validation across the collection Add skillcheck.toml and fix genuine issues surfaced by the skillcheck static analyzer so all 513 SKILL.md files (source + materialized) validate. - skillcheck.toml: ignore references.broken-link (our skills document target-repo paths, generated outputs, and example paths a static checker cannot tell apart from bundled files) and skip-dirname-check (the source tree nests related skills; dir == name only holds post-materialization). references.escape is kept on as a security check. - phoenix-tracing: drop 4 dead links to references/attributes-*.md files that were never shipped (genuine broken progressive-disclosure links). - qdrant-scaling: convert 4 cross-skill ../SKILL.md links to portable text references so each skill stays self-contained. - mvvm-toolkit-messenger: remove angle-bracket generics from the description so it no longer trips the xml-tags rule. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> @
fhwvtqdc2q-svg
force-pushed
the
skillcheck-validation
branch
from
de8af7e to
4edbf66
Compare
Contributor
|
🔴 Contributor Reputation Check: HIGH risk
Maintainers: please review this contributor before merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Brings the skill collection into compliance with skillcheck validation and adds a repo-level
skillcheck.tomlconfiguration.Changes
skillcheck.toml(new): repo-level skillcheck config. Documents whyreferences.broken-linkis ignored (SKILL.md files legitimately document target-repo paths, run-time-generated files, and illustrative example paths that a static checker cannot distinguish from real broken links), keeps thereferences.escapesecurity check ON (path-traversal / CWE-59), and skips the dirname check (source lives in a nestedskills/tree;nameis the flattened identifier materialised at build time).skills/mvvm-toolkit-messenger/SKILL.mdskills/qdrant-scaling/minimize-latency/SKILL.mdskills/qdrant-scaling/scaling-data-volume/vertical-scaling/SKILL.mdskills/qdrant-scaling/scaling-qps/SKILL.mdskills/phoenix-tracing/SKILL.mdandplugins/phoenix/skills/phoenix-tracing/SKILL.mdValidation
npm run skill:validate→ ✅ All 350 skills are valid.Notes for reviewers