-
Notifications
You must be signed in to change notification settings - Fork 438
Test connections to private registries in start-proxy
#3466
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
e89464b to
01ee641
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Adds an (FF-gated) connectivity check in the start-proxy action to probe each configured private registry and log the outcome, along with the supporting types, tests, and dependency updates.
Changes:
- Introduces
checkConnections+ReachabilityBackendabstraction to test registry reachability via the local proxy. - Updates
start-proxy-actionto return proxy connection details and (optionally) run the reachability checks behind a new feature flag. - Adds
https-proxy-agentdependency and the newstart_proxy_connection_checksfeature flag.
Reviewed changes
Copilot reviewed 18 out of 20 changed files in this pull request and generated 34 comments.
Show a summary per file
| File | Description |
|---|---|
| src/start-proxy/types.ts | Adds shared types for registries/credentials and a ProxyInfo return type. |
| src/start-proxy/reachability.ts | Implements proxy-based reachability checks and related error type/backends. |
| src/start-proxy/reachability.test.ts | Adds unit tests for reachability-check logging and filtering behavior. |
| src/start-proxy.ts | Moves Credential definition to shared types and re-exports types. |
| src/start-proxy-action.ts | Initializes feature flags and (FF-gated) triggers reachability checks after starting proxy. |
| src/feature-flags.ts | Adds StartProxyConnectionChecks feature flag + env var wiring. |
| package.json | Adds https-proxy-agent dependency. |
| package-lock.json | Locks https-proxy-agent dependency version and metadata. |
| lib/upload-sarif-action.js | Generated JS update reflecting dependency/feature-flag additions. |
| lib/upload-sarif-action-post.js | Generated JS update reflecting dependency/feature-flag additions. |
| lib/upload-lib.js | Generated JS update reflecting dependency/feature-flag additions. |
| lib/start-proxy-action-post.js | Generated JS update reflecting dependency/feature-flag additions. |
| lib/setup-codeql-action.js | Generated JS update reflecting dependency/feature-flag additions. |
| lib/resolve-environment-action.js | Generated JS update reflecting dependency/feature-flag additions. |
| lib/init-action.js | Generated JS update reflecting dependency/feature-flag additions. |
| lib/init-action-post.js | Generated JS update reflecting dependency/feature-flag additions. |
| lib/autobuild-action.js | Generated JS update reflecting dependency/feature-flag additions. |
| lib/analyze-action.js | Generated JS update reflecting dependency/feature-flag additions. |
| lib/analyze-action-post.js | Generated JS update reflecting dependency/feature-flag additions. |
Modifies the
start-proxyaction to perform a basic connectivity test for each configured private registry. The outcomes of these tests are logged. The implementation is designed to be tolerant to failures and is gated behind a new FF.Note that this PR includes the approved changes from #3438 in the first commit.
Risk assessment
For internal use only. Please select the risk level of this change:
Which use cases does this change impact?
Workflow types:
dynamicworkflows (Default Setup, CCR, ...).Products:
analysis-kinds: code-scanning.analysis-kinds: code-quality.Environments:
github.comand/or GitHub Enterprise Cloud with Data Residency.How did/will you validate this change?
.test.tsfiles).pr-checks).If something goes wrong after this change is released, what are the mitigation and rollback strategies?
How will you know if something goes wrong after this change is released?
Are there any special considerations for merging or releasing this change?
Merge / deployment checklist