-
Notifications
You must be signed in to change notification settings - Fork 479
Support CodeQL versions, ranges, release offsets, and nightly transitions #4079
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
felickz
wants to merge
10
commits into
github:main
Choose a base branch
from
forks-felickz:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
8c514cb
Support bare CodeQL CLI version numbers in the tools input
Copilot 16c4f3e
Add latest-N offset and semver range support for tools input
Copilot eccc888
Clarify tools input resolution order and add URL disambiguation tests
Copilot 18e73d3
Include available version range in latest-N/semver-range error messages
Copilot ada6eaf
Add latest-prerelease and nightly-until<version> tools input forms
Copilot 06da642
Require a separator before the version in nightly-until forms; fix pr…
Copilot 8f22549
Fix GHES multi-host resolution bug in getSortedCliVersions
Copilot 71844e5
Replace nightly-until-stable-<version> with nightly-until-default-<ve…
Copilot 9892b52
Add tests for nightly-until-default overlay-aware and GHES override s…
Copilot 5ede042
Merge pull request #2 from forks-felickz/copilot/add-version-support-…
felickz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -10,6 +10,24 @@ inputs: | |
|
|
||
| - A local path to a CodeQL Bundle tarball, or | ||
| - The URL of a CodeQL Bundle tarball GitHub release asset, or | ||
| - A CodeQL CLI version number, for example `2.19.0` or `v2.19.0`, in which case the CodeQL | ||
| Bundle containing that version will be downloaded, selecting the archive format and | ||
| release asset that matches the runner's operating system and architecture, or | ||
| - A CodeQL CLI version range, for example `2.24.x`, `2.x`, `~2.24.0`, or `^2.24.0`, in | ||
| which case the most recent stable CodeQL Bundle release satisfying that range will be | ||
| downloaded, or | ||
| - `latest-<N>`, for example `latest-1` or `LATEST-2` (matching is case insensitive), which | ||
| uses the CodeQL Bundle release `N` stable releases before the most recent one, or | ||
| - A special value `latest-prerelease` (matching is case insensitive) which uses the most | ||
| recent CodeQL Bundle release, whether it is a stable release or a GitHub prerelease, or | ||
| - `nightly-until-<version>`, for example `nightly-until-2.24.0` or | ||
| `NIGHTLY-UNTIL-2.24.0` (matching is case insensitive), which uses the most recent CodeQL | ||
| Bundle release satisfying that version threshold, considering GitHub prereleases too, or | ||
| falls back to the latest nightly version of the CodeQL tools if no such release exists, or | ||
| - `nightly-until-default-<version>`, for example `nightly-until-default-2.24.0` (matching | ||
| is case insensitive), which uses the default CodeQL CLI version if it satisfies that | ||
| version threshold, or falls back to the latest nightly version of the CodeQL tools | ||
| otherwise, or | ||
|
Comment on lines
+13
to
+30
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Currently, we (deliberately) don't document all existing inputs here because they generally cause more harm than good when used incorrectly. We should think carefully about which formats are worth documenting here once we have agreed on all the formats. |
||
| - A special value `linked` which uses the version of the CodeQL tools | ||
| that the Action has been bundled with. | ||
| - A special value `nightly` which uses the latest nightly version of the | ||
|
|
||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is probably an excessive amount of release notes for this group of changes, especially given that we would not expect most people to use any of this. Consider condensing it to just something like