Open
Conversation
asgerf
force-pushed
the
browser-sources
branch
from
7c18abb to
2328523
Compare
asgerf
changed the title
asgerf
force-pushed
the
browser-sources
branch
from
2328523 to
2a41ff2
Compare
Napalys
approved these changes
Mar 12, 2026
Contributor
Napalys
left a comment
Napalys
left a comment
There was a problem hiding this comment.
Looks great, couple of small nits. 👍
| predicate isUrl() { this = "url" } | ||
| predicate isUrl() { this = "browser-url" } | ||
|
|
||
| /** Holds if this is the `query` or `fragment` kind. */ |
Contributor
There was a problem hiding this comment.
Nit:
We could update the ql doc to reflect the changes?
Contributor
There was a problem hiding this comment.
| request(window.location.href + '?q=123'); | ||
|
|
||
| const custom = require('testlib').getBrowserSource(); // $ Source[js/client-side-request-forgery] | ||
| request(custom) // $ Alert[js/client-side-request-forgery]; |
Contributor
There was a problem hiding this comment.
I think that semicolumn does not belong there?
Suggested change
| request(custom) // $ Alert[js/client-side-request-forgery]; | |
| request(custom) // $ Alert[js/client-side-request-forgery] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, sources contributed via MaD would always be seen as server-side sources, but now client-side sources can be contributing using one of the following source kinds:
browserbrowser-window-name(window.name)browser-message-eventbrowser-url(window.location.href)browser-url-querybrowser-url-fragmentbrowser-url-pathNo additional threat models have been added. The above source kinds are activated as part of the
remotethreat model, but many queries treat them differently from server-side sources.See also discussion here (internal link).