Close Language Gaps for Commands + Dialogs/Elicitations#960
Merged
MRayermannMSFT merged 25 commits intomainfrom Apr 2, 2026
Merged
Close Language Gaps for Commands + Dialogs/Elicitations#960MRayermannMSFT merged 25 commits intomainfrom
MRayermannMSFT merged 25 commits intomainfrom
Conversation
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR closes feature parity gaps across the SDKs by adding slash commands and UI elicitation dialogs / elicitation callbacks, including capability reporting and multi-client broadcast behavior (capabilities/commands changed) with corresponding docs and tests.
Changes:
- Adds command registration +
command.executedispatch/response handling across Python, Go, and .NET. - Adds UI elicitation APIs (confirm/select/input/custom schema),
onElicitationRequestcallback handling, andcapabilitiesplumbing (create/resume response +capabilities.changed). - Adds/updates E2E + unit tests and replay snapshots to cover single- and multi-client scenarios.
Reviewed changes
Copilot reviewed 36 out of 36 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| test/snapshots/multi_client/client_receives_commands_changed_when_another_client_joins_with_commands.yaml | New replay snapshot for multi-client commands broadcast scenario |
| test/snapshots/multi_client/capabilities_changed_fires_when_second_client_joins_with_elicitation_handler.yaml | New replay snapshot for multi-client capabilities enablement scenario |
| test/snapshots/multi_client/capabilities_changed_fires_when_elicitation_provider_disconnects.yaml | New replay snapshot for multi-client capabilities disablement scenario |
| test/snapshots/elicitation/session_without_elicitationhandler_reports_no_capability.yaml | New replay snapshot for elicitation capability baseline |
| test/snapshots/elicitation/session_without_elicitationhandler_creates_successfully.yaml | New replay snapshot for session creation without elicitation handler |
| test/snapshots/elicitation/session_without_elicitation_handler_reports_no_capability.yaml | New replay snapshot variant for elicitation capability baseline |
| test/snapshots/elicitation/session_with_elicitationhandler_reports_elicitation_capability.yaml | New replay snapshot for elicitation capability when handler is present |
| test/snapshots/elicitation/session_with_elicitation_handler_reports_elicitation_capability.yaml | New replay snapshot variant for elicitation capability when handler is present |
| test/snapshots/elicitation/sends_requestelicitation_when_handler_provided.yaml | New replay snapshot for requestElicitation flag behavior |
| test/snapshots/elicitation/elicitation_throws_when_capability_is_missing.yaml | New replay snapshot for capability-gated UI API behavior |
| test/snapshots/elicitation/defaults_capabilities_when_not_provided.yaml | New replay snapshot for default capabilities behavior |
| test/snapshots/commands/session_with_no_commands_creates_successfully.yaml | New replay snapshot for session creation with no commands |
| test/snapshots/commands/forwards_commands_in_session_resume.yaml | New replay snapshot for resume payload forwarding commands |
| test/snapshots/commands/forwards_commands_in_session_create.yaml | New replay snapshot for create payload forwarding commands |
| python/test_commands_and_elicitation.py | New Python unit coverage for commands, elicitation APIs/callbacks, and capabilities.changed |
| python/README.md | Documents Python commands + UI elicitation + elicitation request handler semantics |
| python/e2e/test_ui_elicitation.py | Python E2E tests for capability gating + capability reporting with handler |
| python/e2e/test_ui_elicitation_multi_client.py | Python E2E multi-client tests for capabilities.changed enable/disable behavior |
| python/e2e/test_commands.py | Python E2E multi-client test for commands.changed broadcast |
| python/copilot/session.py | Implements Python command routing, UI elicitation API, elicitation callback handling, and capabilities updates |
| python/copilot/client.py | Wires commands + requestElicitation flags into create/resume payloads; stores capabilities from responses; improves TCP socket termination |
| python/copilot/init.py | Exposes newly added Python public types (commands/elicitation/capabilities/UI API) |
| go/types.go | Adds Go commands/elicitation/capabilities types and a new Int() pointer helper |
| go/session.go | Implements Go command routing, UI elicitation API, elicitation callback handling, and capabilities storage |
| go/session_test.go | Adds Go unit tests for command routing + capabilities + elicitation gating/handler storage |
| go/client.go | Serializes commands + requestElicitation and registers handlers; stores capabilities from responses |
| go/client_test.go | Adds Go request/response serialization tests for commands + requestElicitation + capabilities |
| go/README.md | Documents Go commands + UI elicitation + elicitation request handling |
| go/internal/e2e/commands_and_elicitation_test.go | Adds Go E2E coverage for commands + elicitation + multi-client capabilities changes |
| dotnet/test/MultiClientCommandsElicitationTests.cs | Adds .NET E2E multi-client tests for commands.changed and capabilities.changed enable/disable |
| dotnet/test/ElicitationTests.cs | Adds .NET E2E + type-structure tests for elicitation + capabilities gating |
| dotnet/test/CommandsTests.cs | Adds .NET E2E + type-structure tests for commands + config cloning |
| dotnet/src/Types.cs | Adds .NET public types for commands, elicitation, UI API, and capabilities; extends config cloning |
| dotnet/src/Session.cs | Implements .NET command routing, elicitation callback handling, UI API, and capabilities updates |
| dotnet/src/Client.cs | Adds commands + requestElicitation to wire requests; stores capabilities from responses; adds JSON source-gen types |
| dotnet/README.md | Documents .NET commands + UI elicitation + elicitation request handler behavior |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
MRayermannMSFT
force-pushed
the
mrayermannmsft/uiandcommandsgaps
branch
from
1d0a155 to
0c4ff33
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
MackinnonBuck
previously approved these changes
Apr 2, 2026
Collaborator
MackinnonBuck
left a comment
MackinnonBuck
left a comment
There was a problem hiding this comment.
Looks great! Just a minor nit.
This comment has been minimized.
This comment has been minimized.
test/snapshots/commands/forwards_commands_in_session_create.yaml
Outdated
Show resolved
Hide resolved
…apabilities.changed reliably in replay proxy
…connect Python's socket.makefile() holds its own reference to the socket. Calling socket.close() alone won't release the OS-level resource until the makefile wrapper is also closed. This meant force_stop() wasn't actually closing the TCP connection, so the server never detected the disconnect and never sent capabilities.changed events to other clients. Fix: close the file wrapper before the socket in SocketWrapper.terminate(). Unskip test_capabilities_changed_when_elicitation_provider_disconnects.
- Narrow generic catch clauses in .NET command/elicitation handlers with 'when (ex is not OperationCanceledException)' filter - Remove redundant null-conditional (val?.ToString -> val.ToString) in SelectAsync and InputAsync switch expressions - Add explanatory comments to Python empty except blocks
…nect socket.close() and file wrapper close don't reliably interrupt a blocking readline() on another thread in Python. socket.shutdown(SHUT_RDWR) sends TCP FIN to the server immediately (triggering server-side disconnect detection) and interrupts any pending blocking reads across threads — matching Node.js socket.destroy() and Go conn.Close() behavior.
Go was only passing RequestedSchema.Properties to the elicitation handler, dropping the 'type' and 'required' fields. This meant handlers couldn't reconstruct the full JSON Schema. Now passes a complete map with type, properties, and required. Also replaces custom containsString/searchSubstring helpers in Go tests with strings.Contains, and adds tests in Go and Python that verify the full schema is passed through to elicitation handlers.
Use direct schema extraction logic test instead of dispatching through session event machinery, avoiding need for RPC mocks. Fixes undefined SessionEventData and handleEvent references.
…tests - Command handler error propagation: verifies handler error is returned - Unknown command: verifies getCommandHandler returns false for unknown - Elicitation handler error: verifies error propagation from handler - Elicitation handler success: verifies result with action and content
…ET README Matches Go and Python README structure where these are ## (h2) sections rather than ### (h3) subsections. Closes documentation gap flagged by SDK Consistency Review Agent.
.NET: - Cache SessionUiApiImpl instance via Lazy<> instead of allocating on every .Ui access - Await command/elicitation handler calls instead of redundant fire-and-forget (outer caller already fire-and-forgets) - Use ElicitationRequestedDataMode enum for Mode instead of string Go: - Handle SessionEventTypeCapabilitiesChanged in handleBroadcastEvent to update session capabilities when other clients join/leave with elicitation handlers - Add test verifying capabilities.changed event updates session
…tationContext Combines the two-argument elicitation handler pattern into a single ElicitationContext type across all three SDKs, matching the existing CommandContext pattern. The context now includes SessionId alongside the request fields (Message, RequestedSchema, Mode, etc.). Changes per language: - .NET: ElicitationContext class, single-arg delegate, Lazy<> cached Ui - Go: ElicitationContext struct, single-arg handler func - Python: ElicitationContext TypedDict, single-arg callable All tests, READMEs, and E2E tests updated.
Consistent with Python, Go, and .NET — ElicitationRequest is now ElicitationContext with sessionId included. Handler takes single arg. Completes the cross-SDK consistency change.
MRayermannMSFT
force-pushed
the
mrayermannmsft/uiandcommandsgaps
branch
from
255b375 to
dd594c0
Compare
- Replace Lazy<ISessionUiApi> with simple auto-property initialized in constructor, per reviewer feedback - Delete 14 empty snapshot YAML files (commands, elicitation, multi_client) that had no conversation data
Renamed to accurately reflect what they verify: - Forwards_Commands_In_Session_Create -> Session_With_Commands_Creates_Successfully - Forwards_Commands_In_Session_Resume -> Session_With_Commands_Resumes_Successfully Actual forwarding verification is in the multi-client test Client_Receives_Commands_Changed_When_Another_Client_Joins_With_Commands which proves the server received the commands by checking the commands.changed event on another client.
This comment has been minimized.
This comment has been minimized.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Generated by SDK Consistency Review Agent for issue #960
Contributor
Cross-SDK Consistency Review ✅ (with one minor finding)This PR does an excellent job closing the Commands + UI Elicitation feature gap across all four SDKs. The API surfaces are well-aligned:
The Node.js One Python naming inconsistency flaggedThe only cross-language consistency issue found is in the Python SDK's public API types, where several new TypedDicts use camelCase field names instead of Python-conventional snake_case:
The parallel Everything else — wire protocol, session lifecycle integration, event routing, capability gating, and test coverage — looks well-implemented and consistent across all four SDKs.
|
Contributor
There was a problem hiding this comment.
Generated by SDK Consistency Review Agent for issue #960
MackinnonBuck
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds Commands and UI Elicitation support to the Python, Go, and .NET SDKs, closing the feature gap with the Node.js reference implementation. Each SDK now supports registering slash commands, handling elicitation requests from the server, and driving interactive form dialogs (confirm, select, input) through a capability-gated UI API — with full documentation, unit tests, and E2E tests matching the Node.js test surface.
Why
These two features were recently shipped in the Node.js SDK only, leaving the other three languages unable to participate in command dispatch or elicitation flows. Any multi-language deployment that relied on commands or form-based user input would have been forced to use the Node.js SDK exclusively. Closing this gap ensures all four SDKs offer the same capabilities, preventing fragmentation and letting teams choose the language that fits their stack.
The Node.js
ElicitationHandlersignature has changed from two arguments to one. The separateElicitationRequestand{ sessionId }invocation types have been merged into a singleElicitationContexttype that includessessionIdalongside the request fields. This mirrors the existingCommandContextsingle-argument pattern.Before:
After:
Python, Go, and .NET are not affected — Commands and Elicitation are new APIs in those SDKs and ship with the
ElicitationContextsingle-argument pattern from the start.