Closed
Conversation
There was a problem hiding this comment.
PR Overview
This PR updates the GitHubOrg class by adding support for a new role: "security-manager".
- Added a new mapping for "security-manager" in the ORGANIZATION_ROLES hash.
- Ensured proper comma separation in the hash entries.
Changes
| File | Description |
|---|---|
| lib/entitlements/backend/github_org.rb | Added "security-manager" role to the ORGANIZATION_ROLES hash |
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
Tip: Copilot only keeps its highest confidence comments to reduce noise and keep you focused. Learn more
Contributor
|
Org roles API endpoint suggests this should be $ gh api \
-H "Accept: application/vnd.github+json" \
-H "X-GitHub-Api-Version: 2022-11-28" \
/orgs/github/organization-roles --jq .roles[].name
Manage Runners
API Insights Viewers
all_repo_admin
all_repo_maintain
all_repo_read
all_repo_triage
all_repo_write
ci_cd_admin
security_manager |
Member
Author
|
Ah thanks, wasn't sure if it was |
Member
Author
|
Closing because we don't need/want always-on-users for security-manager. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes an update to the
GitHubOrgclass in thelib/entitlements/backend/github_org.rbfile to support a new role. The most important change is the addition of the "security-manager" role to theORGANIZATION_ROLEShash.lib/entitlements/backend/github_org.rb: Added "security-manager" role to theORGANIZATION_ROLEShash./cc https://github.com/github/entitlements/pull/101743#issuecomment-2656664339
/cc https://github.com/github/security-services/issues/190