Skip to content

ci: disable Firecracker workflows and release artifacts - #7346

Merged
lpcox merged 1 commit into
mainfrom
disable-firecracker-workflows
Aug 14, 2026
Merged

ci: disable Firecracker workflows and release artifacts#7346
lpcox merged 1 commit into
mainfrom
disable-firecracker-workflows

Conversation

@lpcox

@lpcox lpcox commented Aug 14, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • remove the dedicated Firecracker preview integration workflow
  • stop building and publishing Firecracker preview artifacts from releases
  • update integration, configuration, and release documentation to reflect that Firecracker validation is now local-only

Validation

  • parsed .github/workflows/release.yml with js-yaml
  • ran the full Jest suite (311 suites, 4,882 tests)
  • commit hooks completed lint and TypeScript build

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings August 14, 2026 01:11
@github-actions

Copy link
Copy Markdown
Contributor

Documentation Preview

Documentation build failed for this PR. View logs.

Built from commit ffc7682

@lpcox
lpcox merged commit a299491 into main Aug 14, 2026
27 of 28 checks passed

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes automated Firecracker preview validation and release artifacts, leaving Firecracker testing as an explicit local-only process.

Changes:

  • Deletes the dedicated Firecracker integration workflow.
  • Removes Firecracker artifact build, staging, and publication from releases.
  • Updates Firecracker and Cloud Hypervisor documentation for the local-only validation model.
Show a summary per file
File Description
.github/workflows/test-firecracker.yml Removes Firecracker artifact and live-KVM CI jobs.
.github/workflows/release.yml Stops building and publishing Firecracker preview assets.
docs/releasing.md Documents that releases no longer include Firecracker artifacts.
docs/INTEGRATION-TESTS.md Describes Firecracker validation as local-only.
docs/firecracker-integration.md Revises artifact and automation guidance.
docs/cloud-hypervisor-foundation.md Updates comparisons with Firecracker CI.
docs/awf-config-spec.md Documents locally built Firecracker test artifacts.

Review details

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Suppressed comments (1)

docs/firecracker-integration.md:903

  • The new statement that Actions no longer invokes Firecracker validation conflicts with this guide's remaining claims that CI supports GitHub-hosted Ubuntu at lines 17-19, 252-257, and 1084. The same stale CI-support claim also remains in docs/architecture.md and docs/compatibility.md. Recast those as requirements for the retained local validation scripts; otherwise the documentation still advertises CI coverage that this PR removes.
The dedicated Firecracker Actions workflow is disabled. Artifact build,
verification, host preflight, and live smoke scripts remain in the repository
for explicit local use, but GitHub Actions does not invoke them.
  • Files reviewed: 7/7 changed files
  • Comments generated: 4
  • Review effort level: Balanced

Comment on lines +361 to 364
Automated Firecracker artifact builds and release publication are disabled.
The reproducible artifact set can still be built explicitly with
`guest/firecracker/build-test-artifacts.sh`; its output includes
`release/firecracker-test-x86_64/awf-firecracker-test-x86_64.tar.gz`.
Comment on lines +397 to +401
based on the retained
[Firecracker test conventions](./firecracker-integration.md#part-14--ci-workflow)
but adapted for this backend's GitHub-hosted-only support statement and
jailer-free launcher.
jailer-free launcher. The corresponding Firecracker Actions workflow is
disabled.
Comment thread docs/awf-config-spec.md
Comment on lines +317 to +319
The `firecracker-test-x86_64` x86_64 test/preview artifacts can be built
explicitly from the repository, but are not built or published by GitHub
Actions. They are not production defaults and are never auto-downloaded. See
Comment thread docs/INTEGRATION-TESTS.md
Comment on lines +202 to +204
The live smoke/security suite verifies all five SHA-256 digests before running.
Its preflight requires usable KVM and fails closed if `/dev/kvm` or another
required host capability is unavailable.
@lpcox
lpcox deleted the disable-firecracker-workflows branch August 14, 2026 01:14
@github-actions

Copy link
Copy Markdown
Contributor

✅ Coverage Check Passed

Overall Coverage

Metric Base PR Delta
Lines 93.82% 93.84% 📈 +0.02%
Statements 92.67% 92.68% 📈 +0.01%
Functions 92.60% 92.60% ➡️ +0.00%
Branches 85.81% 85.82% ➡️ +0.01%
📁 Per-file Coverage Changes (1 files)
File Lines (Before → After) Statements (Before → After)
src/log-directory-setup.ts 96.2% → 100.0% (+3.78%) 96.3% → 100.0% (+3.71%)

Coverage comparison generated by scripts/ci/compare-coverage.ts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants