-
Notifications
You must be signed in to change notification settings - Fork 97
Update noop comment footer and move issue template to markdown file #14602
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
pelikhan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot move template to actions/setup/md and render
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
actions/setup/md/noop_runs_issue.md
Outdated
| ### Resources | ||
|
|
||
| - [GitHub Agentic Workflows Documentation](https://github.com/github/gh-aw) | ||
| - [Safe Outputs Reference](https://github.com/github/gh-aw/blob/main/docs/src/content/docs/reference/safe-outputs.md) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot Remove line
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. Removed the Safe Outputs Reference link from the template. Commit: 31a4bc2
|
|
||
| --- | ||
|
|
||
| > This issue is automatically managed by GitHub Agentic Workflows. Do not close this issue manually. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- add one more comment: no action to take, do not assign to an agent.
- add xml marker
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. Added "No action to take - Do not assign to an agent" instruction and <!-- gh-aw-noop-runs --> XML marker. Commit: f5a5635
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Updates how “no-op runs” are tracked and displayed by switching the no-op issue body to a dedicated markdown template file and adjusting the posted comment footer format to match other workflow-generated footers.
Changes:
- Add
actions/setup/md/noop_runs_issue.mdas the source template for the “[agentic-workflows] No-Op Runs” parent issue body. - Update
handle_noop_message.cjsto load the template from/opt/gh-aw/prompts/noop_runs_issue.mdand change the no-op comment footer to quote-markdown format (and remove timestamp). - Update tests to mock
fs.readFileSyncfor template loading.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| actions/setup/md/noop_runs_issue.md | Introduces a dedicated markdown template for the no-op runs parent issue body. |
| actions/setup/js/handle_noop_message.cjs | Loads issue body template from prompts dir and updates the posted comment footer formatting. |
| actions/setup/js/handle_noop_message.test.cjs | Mocks template loading via fs.readFileSync to support the new runtime template dependency. |
Comments suppressed due to low confidence (2)
actions/setup/js/handle_noop_message.cjs:55
generateFooterWithExpirationappends the> - [x] expires ...line to the very end ofparentBodyContent. Because the template ends with an XML marker (<!-- gh-aw-noop-runs -->), this will place the expiration line after the marker and break the “marker-at-end” layout (and the helper comment says expiration should be inside the quoted section). UseaddExpirationToFooter(parentBodyContent, expiresHours, ...)(or otherwise insert the expiration line before the XML marker) so the XML marker stays last and the expiration stays in the intended quoted block.
// Load template from file
const templatePath = "/opt/gh-aw/prompts/noop_runs_issue.md";
const parentBodyContent = fs.readFileSync(templatePath, "utf8");
// Add expiration marker (30 days from now) inside the quoted section using helper
const footer = generateFooterWithExpiration({
footerText: parentBodyContent,
expiresHours: 24 * 30, // 30 days
});
const parentBody = footer;
actions/setup/js/handle_noop_message.cjs:8
renderTemplateis required but never used in this module. Please remove the unused import to avoid dead code and keep the dependency surface minimal.
const { generateFooterWithExpiration } = require("./ephemerals.cjs");
const { renderTemplate } = require("./messages_core.cjs");
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Plan: Update noop comment footer to use quote markdown syntax
Summary
Updated the noop comment footer and moved the noop runs issue template to a separate markdown file for better maintainability.
Changes Made
> Generated from [workflow_name](run_url)actions/setup/md/noop_runs_issue.mdhandle_noop_message.cjsto read and render the template file<!-- gh-aw-noop-runs -->marker for searchability and programmatic identificationOriginal prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.