Skip to content

Export WithGraphQLFeatures for remote server GraphQL feature flag support #1812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Copilot wants to merge 2 commits into from
Closed

Export WithGraphQLFeatures for remote server GraphQL feature flag support #1812

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
94bc5c3
Initial plan
Copilot Jan 14, 2026
27313fd
Export WithGraphQLFeatures function for remote server usage
Copilot Jan 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions pkg/github/issues.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1789,7 +1789,7 @@ func AssignCopilotToIssue(t translations.TranslationHelperFunc) inventory.Server

// Add the GraphQL-Features header for the agent assignment API
// The header will be read by the HTTP transport if it's configured to do so
ctxWithFeatures := withGraphQLFeatures(ctx, "issues_copilot_assignment_api_support")
ctxWithFeatures := WithGraphQLFeatures(ctx, "issues_copilot_assignment_api_support")

if err := client.Mutate(
ctxWithFeatures,
Expand Down Expand Up @@ -1917,8 +1917,8 @@ func AssignCodingAgentPrompt(t translations.TranslationHelperFunc) inventory.Ser
// graphQLFeaturesKey is a context key for GraphQL feature flags
type graphQLFeaturesKey struct{}

// withGraphQLFeatures adds GraphQL feature flags to the context
func withGraphQLFeatures(ctx context.Context, features ...string) context.Context {
// WithGraphQLFeatures adds GraphQL feature flags to the context
func WithGraphQLFeatures(ctx context.Context, features ...string) context.Context {
return context.WithValue(ctx, graphQLFeaturesKey{}, features)
}

Expand Down
28 changes: 28 additions & 0 deletions pkg/github/issues_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3723,3 +3723,31 @@ func Test_ListIssueTypes(t *testing.T) {
})
}
}

// TestGraphQLFeatures tests the exported GraphQL features context functions
func TestGraphQLFeatures(t *testing.T) {
ctx := context.Background()

// Test that GetGraphQLFeatures returns nil when no features are set
features := GetGraphQLFeatures(ctx)
require.Nil(t, features)

// Test WithGraphQLFeatures adds features to context
ctxWithFeatures := WithGraphQLFeatures(ctx, "feature1", "feature2")
features = GetGraphQLFeatures(ctxWithFeatures)
require.NotNil(t, features)
require.Len(t, features, 2)
assert.Equal(t, "feature1", features[0])
assert.Equal(t, "feature2", features[1])

// Test that the original context is not modified
features = GetGraphQLFeatures(ctx)
require.Nil(t, features)

// Test WithGraphQLFeatures with single feature
ctxWithOneFeature := WithGraphQLFeatures(ctx, "issues_copilot_assignment_api_support")
features = GetGraphQLFeatures(ctxWithOneFeature)
require.NotNil(t, features)
require.Len(t, features, 1)
assert.Equal(t, "issues_copilot_assignment_api_support", features[0])
}