fix(integrations): preserve non-UTF-8 VS Code settings - #3833
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
Author
|
@copilot review |
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes Copilot setup crashes caused by non-UTF-8 VS Code settings while preserving user files.
Changes:
- Handles
UnicodeDecodeErrorthrough the existing preservation fallback. - Adds regression coverage for non-UTF-8 settings.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/specify_cli/integrations/copilot/__init__.py |
Catches UTF-8 decoding failures during settings merge. |
tests/integrations/test_integration_copilot.py |
Verifies preservation and warning behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Collaborator
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3831
A non-UTF-8
.vscode/settings.jsonescapes the existing parse-failure fallback and aborts setup. This handles decode errors through the same preservation path used for malformed JSON, leaving the file unchanged and showing the manual settings guidance.The regression test covers setup with non-UTF-8 settings.