Skip to content

Commit 0648ce8

Browse files
committed
Remove import cycle for query history dto mappers
1 parent 183de7b commit 0648ce8

File tree

4 files changed

+30
-30
lines changed

4 files changed

+30
-30
lines changed
Lines changed: 0 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,7 @@
11
import type { QueryHistoryInfo } from "../query-history-info";
22
import type { QueryHistoryItemDto } from "./query-history-dto";
3-
import { QueryLanguageDto } from "./query-history-dto";
43
import { mapQueryHistoryVariantAnalysisToDomainModel } from "./query-history-variant-analysis-dto-mapper";
54
import { mapLocalQueryItemToDomainModel } from "./query-history-local-query-dto-mapper";
6-
import { QueryLanguage } from "../../common/query-language";
7-
import { assertNever } from "../../common/helpers-pure";
85

96
export function mapQueryHistoryToDomainModel(
107
queries: QueryHistoryItemDto[],
@@ -23,28 +20,3 @@ export function mapQueryHistoryToDomainModel(
2320
);
2421
});
2522
}
26-
27-
export function mapQueryLanguageToDomainModel(
28-
language: QueryLanguageDto,
29-
): QueryLanguage {
30-
switch (language) {
31-
case QueryLanguageDto.CSharp:
32-
return QueryLanguage.CSharp;
33-
case QueryLanguageDto.Cpp:
34-
return QueryLanguage.Cpp;
35-
case QueryLanguageDto.Go:
36-
return QueryLanguage.Go;
37-
case QueryLanguageDto.Java:
38-
return QueryLanguage.Java;
39-
case QueryLanguageDto.Javascript:
40-
return QueryLanguage.Javascript;
41-
case QueryLanguageDto.Python:
42-
return QueryLanguage.Python;
43-
case QueryLanguageDto.Ruby:
44-
return QueryLanguage.Ruby;
45-
case QueryLanguageDto.Swift:
46-
return QueryLanguage.Swift;
47-
default:
48-
assertNever(language);
49-
}
50-
}
Lines changed: 28 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,28 @@
1+
import { QueryLanguageDto } from "./query-history-dto";
2+
import { QueryLanguage } from "../../common/query-language";
3+
import { assertNever } from "../../common/helpers-pure";
4+
5+
export function mapQueryLanguageToDomainModel(
6+
language: QueryLanguageDto,
7+
): QueryLanguage {
8+
switch (language) {
9+
case QueryLanguageDto.CSharp:
10+
return QueryLanguage.CSharp;
11+
case QueryLanguageDto.Cpp:
12+
return QueryLanguage.Cpp;
13+
case QueryLanguageDto.Go:
14+
return QueryLanguage.Go;
15+
case QueryLanguageDto.Java:
16+
return QueryLanguage.Java;
17+
case QueryLanguageDto.Javascript:
18+
return QueryLanguage.Javascript;
19+
case QueryLanguageDto.Python:
20+
return QueryLanguage.Python;
21+
case QueryLanguageDto.Ruby:
22+
return QueryLanguage.Ruby;
23+
case QueryLanguageDto.Swift:
24+
return QueryLanguage.Swift;
25+
default:
26+
assertNever(language);
27+
}
28+
}

extensions/ql-vscode/src/query-history/store/query-history-local-query-dto-mapper.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ import type {
1818
SortedResultSetInfo,
1919
} from "../../common/interface-types";
2020
import { SortDirection } from "../../common/interface-types";
21-
import { mapQueryLanguageToDomainModel } from "./query-history-dto-mapper";
21+
import { mapQueryLanguageToDomainModel } from "./query-history-language-dto-mapper";
2222

2323
export function mapLocalQueryItemToDomainModel(
2424
localQuery: QueryHistoryLocalQueryDto,

extensions/ql-vscode/src/query-history/store/query-history-variant-analysis-dto-mapper.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ import {
2727
import { assertNever } from "../../common/helpers-pure";
2828
import { QueryStatus } from "../query-status";
2929
import type { VariantAnalysisHistoryItem } from "../variant-analysis-history-item";
30-
import { mapQueryLanguageToDomainModel } from "./query-history-dto-mapper";
30+
import { mapQueryLanguageToDomainModel } from "./query-history-language-dto-mapper";
3131

3232
export function mapQueryHistoryVariantAnalysisToDomainModel(
3333
item: QueryHistoryVariantAnalysisDto,

0 commit comments

Comments
 (0)