Add test for removeVariantAnalysis

Author: elenatanasoiu

extensions/ql-vscode/src/remote-queries/variant-analysis-manager.ts

@@ -113,6 +113,10 @@ export class VariantAnalysisManager extends DisposableObject implements VariantA
     return this.variantAnalyses.get(variantAnalysisId);
   }
 
+  public getVariantAnalysesSize(): number {
+    return this.variantAnalyses.size;
+  }
+
   public async loadResults(variantAnalysisId: number, repositoryFullName: string): Promise<void> {
     const variantAnalysis = this.variantAnalyses.get(variantAnalysisId);
     if (!variantAnalysis) {
@@ -127,7 +131,7 @@ export class VariantAnalysisManager extends DisposableObject implements VariantA
     return await fs.pathExists(filePath);
   }
 
-  private async onVariantAnalysisUpdated(variantAnalysis: VariantAnalysis | undefined): Promise<void> {
+  public async onVariantAnalysisUpdated(variantAnalysis: VariantAnalysis | undefined): Promise<void> {
     if (!variantAnalysis) {
       return;
     }

extensions/ql-vscode/src/vscode-tests/cli-integration/remote-queries/variant-analysis-manager.test.ts

@@ -21,6 +21,8 @@ import { createMockVariantAnalysisRepoTask } from '../../factories/remote-querie
 import { CodeQLCliServer } from '../../../cli';
 import { storagePath } from '../global.helper';
 import { VariantAnalysisResultsManager } from '../../../remote-queries/variant-analysis-results-manager';
+import { VariantAnalysis } from '../../../remote-queries/shared/variant-analysis';
+import { createMockVariantAnalysis } from '../../factories/remote-queries/shared/variant-analysis';
 
 describe('Variant Analysis Manager', async function() {
   let sandbox: sinon.SinonSandbox;
@@ -167,6 +169,29 @@ describe('Variant Analysis Manager', async function() {
           expect(getResultsSpy).to.have.been.calledThrice;
         });
       });
+
+      describe('removeVariantAnalysis', async () => {
+        let removeAnalysisResultsStub: sinon.SinonStub;
+        let removeStorageStub: sinon.SinonStub;
+        let dummyVariantAnalysis: VariantAnalysis;
+
+        beforeEach(async () => {
+          dummyVariantAnalysis = createMockVariantAnalysis();
+          removeAnalysisResultsStub = sandbox.stub(variantAnalysisResultsManager, 'removeAnalysisResults');
+          removeStorageStub = sandbox.stub(fs, 'remove');
+        });
+
+        it('should remove variant analysis', async () => {
+          await variantAnalysisManager.onVariantAnalysisUpdated(dummyVariantAnalysis);
+          expect(variantAnalysisManager.getVariantAnalysesSize()).to.eq(1);
+
+          await variantAnalysisManager.removeVariantAnalysis(dummyVariantAnalysis);
+
+          expect(removeAnalysisResultsStub).to.have.been.calledOnce;
+          expect(removeStorageStub).to.have.been.calledOnce;
+          expect(variantAnalysisManager.getVariantAnalysesSize()).to.equal(0);
+        });
+      });
     });
   });
 });