Fix package-lock.json to have acorn as a direct dependency#3930
Merged
Fix package-lock.json to have acorn as a direct dependency#3930
acorn as a direct dependency#3930Conversation
koesie10
force-pushed
the
koesie10/fix-acorn
branch
from
492e16b to
cf91123
Compare
Contributor
There was a problem hiding this comment.
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
Tip: Copilot code review supports C#, Go, Java, JavaScript, Markdown, Python, Ruby and TypeScript, with more languages coming soon. Learn more
Contributor
|
What commands did you run to make these |
Member
Author
robertbrignull
approved these changes
Feb 19, 2025
Contributor
robertbrignull
left a comment
robertbrignull
left a comment
There was a problem hiding this comment.
LGTM
I was mostly worried that future changes might accidentally undo this, perhaps if one of these other packages that depends on acorn gets updated. Hopefully that's unlikely unless the package-lock.json file gets completely discarded and recreated. 🤞🏼
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes
npm run storybookby ensuring thatnode_modules/acornis installed on the same level asnode_modules/acorn-jsx. I'm not sure why we have this discrepancy.