Merged
Conversation
Contributor
There was a problem hiding this comment.
PR Overview
This pull request updates the test plan for GitHub Code Search by adding an expected HttpError scenario during the execution.
- Adjust messaging for the expected HttpError on the first run
- Update expected repository count upon a subsequent run
Reviewed Changes
| File | Description |
|---|---|
| docs/test-plan.md | Updated test plan details to include an expected HttpError when running GitHub Code Search |
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
Tip: Copilot code review supports C#, Go, Java, JavaScript, Markdown, Python, Ruby and TypeScript, with more languages coming soon. Learn more
docs/test-plan.md
Outdated
Comment on lines
493
to
494
| 1. Create a new list, right click and select "Add repositories with GitHub Code Search". Enter the language 'python' and the query "UserMixin". This might result in an HttpError when run for the first time. If so, try again. Whene run for the second time it might show a rate limiting notification after a while or directly populate the list with roughly 900 repositories. | ||
|
|
There was a problem hiding this comment.
There appears to be a typo ('Whene') in the added instruction. Consider correcting it to 'When'.
Suggested change
| 1. Create a new list, right click and select "Add repositories with GitHub Code Search". Enter the language 'python' and the query "UserMixin". This might result in an HttpError when run for the first time. If so, try again. Whene run for the second time it might show a rate limiting notification after a while or directly populate the list with roughly 900 repositories. | |
| 1. Create a new list, right click and select "Add repositories with GitHub Code Search". Enter the language 'python' and the query "UserMixin". This might result in an HttpError when run for the first time. If so, try again. When run for the second time it might show a rate limiting notification after a while or directly populate the list with roughly 900 repositories. |
Contributor
There was a problem hiding this comment.
Suggested change
| 1. Create a new list, right click and select "Add repositories with GitHub Code Search". Enter the language 'python' and the query "UserMixin". This might result in an HttpError when run for the first time. If so, try again. Whene run for the second time it might show a rate limiting notification after a while or directly populate the list with roughly 900 repositories. | |
| 1. Create a new list, right click and select "Add repositories with GitHub Code Search". Enter the language 'python' and the query "UserMixin". This might result in an HttpError when it is run for the first time. If so, try again. When run for the second time it might show a rate limiting notification after a while or directly populate the list with roughly 900 repositories. | |
charisk
approved these changes
Mar 3, 2025
docs/test-plan.md
Outdated
Comment on lines
493
to
494
| 1. Create a new list, right click and select "Add repositories with GitHub Code Search". Enter the language 'python' and the query "UserMixin". This might result in an HttpError when run for the first time. If so, try again. Whene run for the second time it might show a rate limiting notification after a while or directly populate the list with roughly 900 repositories. | ||
|
|
Contributor
There was a problem hiding this comment.
Suggested change
| 1. Create a new list, right click and select "Add repositories with GitHub Code Search". Enter the language 'python' and the query "UserMixin". This might result in an HttpError when run for the first time. If so, try again. Whene run for the second time it might show a rate limiting notification after a while or directly populate the list with roughly 900 repositories. | |
| 1. Create a new list, right click and select "Add repositories with GitHub Code Search". Enter the language 'python' and the query "UserMixin". This might result in an HttpError when it is run for the first time. If so, try again. When run for the second time it might show a rate limiting notification after a while or directly populate the list with roughly 900 repositories. | |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding an expected HttpError when running code search to the testplan.