Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug with the legacyLabelRegex by resetting its lastIndex before running test(), ensuring that the regex always starts searching from the beginning of the string.
- Resets lastIndex on legacyLabelRegex to prevent stateful matching issues
- Ensures legacy labels are processed correctly when used repeatedly
Tip: Copilot only keeps its highest confidence comments to reduce noise and keep you focused. Learn more
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the
legacyLabelRegexis tested multiple times against the same string (as happens most of the time, unless a user-specified label is added), it would start searching from the end of the previous match instead of from the start of the string:“JavaScript RegExp objects are stateful when they have the global or sticky flags set (e.g., /foo/g or /foo/y). They store a lastIndex from the previous match. Using this internally, test() can be used to iterate over multiple matches in a string of text (with capture groups).”
This fixes it by resetting
lastIndexbefore running thetestmethod.