Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR removes the use of VSCodeLink and replaces it with a new Link component to support the migration away from @vscode/webview-ui-toolkit, implementing styles similar to the original component.
- Removed VSCodeLink usage and import statements across multiple files.
- Introduced a new Link component in extensions/ql-vscode/src/view/common/Link.tsx.
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| extensions/ql-vscode/src/view/variant-analysis/VariantAnalysisStatusStats.tsx | Replaced VSCodeLink with Link for viewing action logs. |
| extensions/ql-vscode/src/view/variant-analysis/RawResultCell.tsx | Replaced VSCodeLink with Link for link rendering in raw result cells. |
| extensions/ql-vscode/src/view/variant-analysis/FailureReasonAlert.tsx | Updated error alert to use the new Link component for log viewing. |
| extensions/ql-vscode/src/view/common/Link.tsx | Introduced the new Link component with basic styled-components styling. |
| extensions/ql-vscode/src/view/common/FileCodeSnippet/FileCodeSnippet.tsx | Replaced VSCodeLink with Link for linking to file code snippets. |
| extensions/ql-vscode/src/stories/common/Alert.stories.tsx | Updated stories to use the new Link component in alerts. |
Tip: Leave feedback on Copilot's review comments with the 👎 and 👍 buttons to help improve review quality. Learn more
robertbrignull
left a comment
There was a problem hiding this comment.
Kinda wild that the vscode/elements doesn't have a generic link but thanks for adding one that mirrors the old VSCodeLink so we can maintain consistency. At least that way we can choose to change it later on if we want to.
The code and the CSS look fine to me, and thank you for the screenshots showing the different states ❤️
I've also tried it out locally and the links are functioning normally as far as I can tell
This is part of the work to remove the use of
@vscode/webview-ui-toolkit. The new library@vscode-elements/elementsdoes not have a direct replacement forVsCodeLink, this implements a newLinkcomponent for which the styles have been mostly copied from here. I have attached comparison screenshots of the old and new component.Regular styles

Hovered styles

Focused styles
