rename agency_params → copilot_params, remove built-in MCP spawning, and update docs#135
Conversation
…eferences with copilot Agent-Logs-Url: https://github.com/githubnext/ado-aw/sessions/6de925b5-b695-4ace-ace7-292d6f1896a2 Co-authored-by: jamesadevine <4742697+jamesadevine@users.noreply.github.com>
agency_params → copilot_params and replace agency CLI references with copilot
|
@copilot let's remove the code related to |
Agent-Logs-Url: https://github.com/githubnext/ado-aw/sessions/d23028c8-f3ae-424f-a2cc-6adb95730353 Co-authored-by: jamesadevine <4742697+jamesadevine@users.noreply.github.com>
Done in 5850571. Removed both Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Expand the update-awf-version workflow to also check for new releases of github/copilot-cli and open PRs to update the COPILOT_CLI_VERSION constant. Bumps max PRs from 1 to 2 to allow both dependencies to be updated in a single run. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
agency_params → copilot_params and replace agency CLI references with copilotagency references and replace with copilot_params; remove built-in MCP spawning via agency mcp
AGENTS.md
Outdated
| │ │ │ │ │ ado MCP │ | ||
| │ Agent │────▶│ MCP Firewall │────▶│ (agency mcp ado)│ | ||
| │ Agent │────▶│ MCP Firewall │────▶│ (copilot mcp ado)│ |
There was a problem hiding this comment.
@copilot we no longer have built in mcps like agency had - no copilot map ado or copilot map icm. The only built in mcps come from the copilot cli itself. everything else is added by the user.
There was a problem hiding this comment.
Done in 4c81411. Removed all agency-style built-in MCP references from AGENTS.md:
- Architecture diagram no longer shows
(copilot mcp ado)/(copilot mcp icm)— now shows only custom MCPs - Firewall config format example no longer has
ado/icm/kustoentries usingcopilot mcp *commands - Removed the "Built-in MCP Servers" subsection and its list of
ado,icm,kusto, etc. - The
mcp-servers:section now only documents custom MCPs (those requiring acommand:field) - Updated
{{ copilot_params }}to clarify--disable-builtin-mcps/--mcprefer to the Copilot CLI's own native MCPs, not agency-style ones
AGENTS.md
Outdated
| │ │ │ │ │ ado MCP │ | ||
| │ Agent │────▶│ MCP Firewall │────▶│ (agency mcp ado)│ | ||
| │ Agent │────▶│ MCP Firewall │────▶│ (copilot mcp ado)│ |
There was a problem hiding this comment.
@copilot we no longer have built in mcps like agency had - no copilot map ado or copilot map icm. The only built in mcps come from the copilot cli itself. everything else is added by the user.
| for tool in allowed_tools { | ||
| if tool.contains('(') || tool.contains(')') || tool.contains(' ') { | ||
| // Use double quotes - the agency_params are embedded inside a single-quoted | ||
| // Use double quotes - the copilot_params are embedded inside a single-quoted |
There was a problem hiding this comment.
@copilot Is this function used? copilot CLI does not have an mcp subcommand.
Agent-Logs-Url: https://github.com/githubnext/ado-aw/sessions/b1199267-7b57-4f8e-b88f-9241078a80c7 Co-authored-by: jamesadevine <4742697+jamesadevine@users.noreply.github.com>
agency references and replace with copilot_params; remove built-in MCP spawning via agency mcpagency_params → copilot_params, remove built-in MCP spawning, and update docs
…ot CLI has no mcp subcommand Agent-Logs-Url: https://github.com/githubnext/ado-aw/sessions/5780d9cc-3b6e-4640-bd7b-df37f2acb416 Co-authored-by: jamesadevine <4742697+jamesadevine@users.noreply.github.com>
Done in 5850571 — both |
🔍 Rust PR ReviewSummary: Needs changes — one test is left broken, one logic/docs mismatch in the 1ES path, and a stale doc example. Findings🐛 Bugs / Logic Issues
|
The MCP server iteration that adds --mcp flags for enabled built-in MCPs was accidentally removed during the agency rename refactor. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot CLI has no built-in MCPs — all MCPs are handled via the MCP firewall. Update the test to assert --mcp flags are not generated. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
All MCPs are now handled via the MCP firewall, not --mcp CLI flags. Renamed 'Agency parameters' to 'Copilot parameters' in test docs. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
The codebase still referred to the old "agency" CLI tool in template markers, variable names, MCP spawn commands, and documentation. All references now reflect the GitHub Copilot CLI, the built-in MCP spawning subcommand code has been removed, and documentation has been updated to remove agency-style built-in MCP concepts.
Changes
{{ agency_params }}→{{ copilot_params }}intemplates/base.ymlandtemplates/1es-base.ymlagency mcp <name>code path fromgenerate_firewall_config()instandalone.rs. MCPs without an explicitcommand:are now skipped entirely.--mcpflag generation removed: Removed the--mcp <name>param generation fromgenerate_copilot_params()incommon.rs— the Copilot CLI has nomcpsubcommand or flag for re-enabling named MCPs.agency_params→copilot_paramsinstandalone.rsandonees.rs, including template replacement tuples$(Build.StagingDirectory)/agency-logs→copilot-logsin 1ES template; removed stale~/.agency/logscopy blocks frombase.ymlAGENTS.mddocumentation: Removed all agency-style built-in MCP references — the architecture diagram, firewall config format,mcp-servers:section, and{{ mcp_configuration }}(1ES) section no longer referenceado/icm/kustoas built-in MCPs. Themcp-servers:section now documents only custom MCPs (those requiring acommand:field). The{{ copilot_params }}section no longer lists--mcp <name>.common.rs,mcp_metadata.rs, andtests/*.md