Serialize Crane workflow runs#110
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(crane): serialize workflow runs
TL;DR
Crane runs can take longer than the schedule interval once a stale migration actually resumes work. This PR adds a repo-wide Crane concurrency group so scheduled and manual Crane invocations do not overlap and race the same migration state.
Problem
After the stale-completion scheduler fix, issue #78 was correctly selected as active work, but multiple Crane runs overlapped while earlier agent jobs were still inside
Execute GitHub Copilot CLI. The compiled default top-level concurrency usedgithub.run_idfor schedule/workflow_dispatch events, which made each run its own lock instead of serializing Crane.Approach
.github/workflows/crane.md:group: crane-${{ github.repository }}cancel-in-progress: falsegh aw compile craneand include the regenerated.github/workflows/crane.lock.yml.Validation
How to test
crane-${{ github.repository }}concurrency group rather than starting another agent job.Trade-offs
cancel-in-progress: falsepreserves in-flight work instead of killing the active agent when a scheduled tick arrives.