chore(deps): update electron-menubar to v10.1.7 - #3115
Merged
Conversation
setchy
approved these changes
Jul 29, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
Bumps
electron-menubarto10.1.7, which carries the fix for the Windows tray hang: gitify-app/electron-menubar#124.What it fixes
On Windows,
positionWindowand the window'sresizelistener recursed into each other:setPositionmakes Windows emitresizesynchronously, which re-enterspositionWindow, which callssetPositionagain. The recursion never unwinds, so the main process wedges with its event loop blocked — the popup never appears and all subsequent tray clicks (left and right) stop responding until the app is restarted.Confirmed from a reporter's instrumented-build log in #3064: the diagnostic heartbeat stops immediately after the menubar
showevent and never resumes, pinning the hang insideshowWindowbetweenemit('show')andemit('after-show'). It matches the two other symptoms reported there — sustained CPU use after the left-click, and a window that grows "somewhat larger than a maximized window" as each recursion pass nudges it.10.1.7guards against re-entrantpositionWindowcalls; a genuine later resize still repositions as before.Why 10.1.7 and not 10.1.5
The fix first shipped in
10.1.5.10.1.6then widened theelectronpeer dependency from an exact pin to>=35.0.0(it was uninstallable for anyone not on the exact version), but that release tagged on GitHub without reaching npm, so it was re-cut as10.1.7. This bump therefore picks up both the tray fix and the peer-range fix.Notes
pnpm-workspace.yamlexcludeselectron-menubar(all versions) from pnpm'sminimumReleaseAgegate rather than pinning one version. It's a first-party package, so the supply-chain delay buys nothing, and this avoids re-editing the exclude on every bump — the gate verifies the existing lockfile before resolving, so a version-pinned entry has to list both old and new version mid-transition.lib/index.cjs,pnpm install --frozen-lockfilepasses the supply-chain check, and the full suite (1198 tests),pnpm check,tsc --noEmitandpnpm buildare all clean.Fixes #3064