feat(ui): fade scrollable content at the top and bottom edges - #3124
Merged
Conversation
github-actions
Bot
added
the
enhancement
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scrollable views currently cut off hard at the top and bottom edges, so content collides abruptly with the header and footer chrome. This adds a
scrollFadeopt-in to the sharedContentslayout component that softly fades content in and out at both edges while scrolling.The fade is driven entirely by CSS scroll-driven animations (
animation-timeline: scroll(self block)) masking the scroll container, so there are no scroll listeners or re-renders, and each edge only fades while there is actually more content to scroll in that direction (measured in Chromium: no top fade at scroll position 0, no bottom fade at the end). Containers whose content fits leave the scroll timeline inactive and render no fade at all.Enabled on Settings, Filters, Accounts, Scopes and the three login screens. Notifications is deliberately left out for now: read notifications are removed from the list, so it can go from overflowing to fitting while mounted, and Chromium holds the last fade value rather than clearing it, which would strand a fade above a list that can no longer scroll.