fix some typos#16
Open
Sen-Zhang wants to merge 1 commit intogo-macaron:masterfrom
Sen-Zhang:fix_typos
Open
Conversation
Author
|
@unknwon Tests against Go 1.3 keep failing on travis. |
Contributor
|
Thanks, I'll remove 1.3 test. Also, I think we should keep old typo method for a while and add a comment to remove it at some point, e.g. |
Closed
Contributor
|
any progress? |
Contributor
|
I think merge would have to wait until we release macaron.v2, thus we'll have session.v2. |
Contributor
|
@unknwon can you work with git-tag's on this repo for versions because of go1.13 thanks |
Contributor
Not everyone is on Go 1.13. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for #15