feat(gooddata-sdk): add CSV upload support for GDSTORAGE data sources#1408
Merged
hkad98 merged 3 commits intogooddata:masterfrom Mar 13, 2026
Merged
feat(gooddata-sdk): add CSV upload support for GDSTORAGE data sources#1408hkad98 merged 3 commits intogooddata:masterfrom
hkad98 merged 3 commits intogooddata:masterfrom
Conversation
hkad98
force-pushed
the
jkd/csv-upload
branch
2 times, most recently
from
28a6177 to
b0919d9
Compare
Add the `result` spec (`/api/v1/schemas/result`) to the Makefile download target and merge it into the combined api-client schema. Regenerate gooddata-api-client, which brings typed endpoints and models for CSV staging upload, CSV analysis, CSV import, file listing, file deletion, and CSV file manifest reading. jira: TRIVIAL risk: low
Add five new methods to CatalogDataSourceService: - staging_upload — upload a CSV to the staging area - analyze_csv — detect columns, types, and parse config - import_csv — import a staged CSV into a GDSTORAGE data source - delete_csv_files — remove files from a data source - upload_csv — end-to-end convenience wrapper Also add CatalogDataSourceGdStorage entity model with _NoCredentials support (GDSTORAGE sources require no authentication), export the new symbol, and add documentation pages for all new methods. jira: TRIVIAL risk: low
…OpenAPI Generator OpenAPI Generator v6.6.0 silently drops the \x00 literal from regex patterns in the generated Python code. The DeclarativeColumn model's `name` field has a spec pattern of `^[^\x00]*$` (reject null bytes, important for Postgres TEXT columns), but the generator produced the invalid Python regex `^[^]*$`, causing `re.PatternError: unterminated character set` at runtime. Fix the generated file and add a post-generation sed fixup to the Makefile `api-client` target so future regenerations are patched automatically. jira: TRIVIAL risk: low
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1408 +/- ##
==========================================
- Coverage 77.53% 77.45% -0.09%
==========================================
Files 225 225
Lines 14614 14661 +47
==========================================
+ Hits 11331 11355 +24
- Misses 3283 3306 +23 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
no23reason
approved these changes
Mar 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
resultOpenAPI spec to api-client generation, bringing typed endpoints and models for CSV staging upload, analysis, import, file listing, and deletionCatalogDataSourceGdStorageentity model with_NoCredentialssupport (GDSTORAGE sources require no authentication)CatalogDataSourceService:staging_upload,analyze_csv,import_csv,delete_csv_files, andupload_csv(end-to-end convenience wrapper)Structure
build): regeneratedgooddata-api-client/with theresultspec — purely mechanical, safe to skimfeat): SDK code, entity model, exports, Makefile change, and docs — the reviewable part