Fix WASM Output Parameters for JS TypedArrays#3100
Open
Adityakk9031 wants to merge 1 commit intogoogle-deepmind:mainfrom
Open
Fix WASM Output Parameters for JS TypedArrays#3100Adityakk9031 wants to merge 1 commit intogoogle-deepmind:mainfrom
Adityakk9031 wants to merge 1 commit intogoogle-deepmind:mainfrom
Conversation
Author
|
@btaba please look into this pr |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3067
Issue
In the WASM bindings, functions that take a JS TypedArray as an output parameter (like
mj_contactForce
,
mj_jac
, etc.) fail to write data back to the array.
This happens because
unpack.h
was interpreting byteOffset of a JS TypedArray as a raw WASM memory pointer. For user-created TypedArrays (which are not views into the WASM heap), byteOffset is just an offset within a JS ArrayBuffer (often 0), leading to writes to invalid memory addresses instead of the JS array.
Solution
Implemented a Copy-In / Copy-Out mechanism for JS TypedArrays in
unpack.h
:
Copy-In: When a JS TypedArray is passed, its data is copied into a temporary C++ std::vector (using convertJSArrayToNumberVector).
Reference Tracking: A reference to the original JS object is stored in UnpackedParam::source_val_.
Copy-Out: Added a
writeBack()
method to
UnpackedParam
. When called, it copies the data from the temporary C++ vector back into the original JS TypedArray using TypedArray.set().
Binding Update: Updated
mj_contactForce_wrapper
to call
writeBack()
after the underlying C function returns.
Changes
wasm/unpack.h
:
Added source_val_ member to
UnpackedParam
.
Updated
FromValue
to handle JS TypedArrays by copying data and storing the reference.
Added
writeBack()
method to sync data back to JS.
wasm/codegen/generated/bindings.cc
:
Added result_.writeBack() to
mj_contactForce_wrapper
.