-
Notifications
You must be signed in to change notification settings - Fork 9.8k
3.0 changes #14533
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
3.0 changes #14533
Conversation
… to patch version v0.16.0-preview.0 and create version 0.16.0-preview.1 (google-gemini#13093) Co-authored-by: Jacob Richman <[email protected]>
… to patch version v0.16.0-preview.1 and create version 0.16.0-preview.2 (google-gemini#13097) Co-authored-by: Adib234 <[email protected]>
… to patch version v0.16.0-preview.2 and create version 0.16.0-preview.3 (google-gemini#13110) Co-authored-by: Jacob Richman <[email protected]>
… to patch version v0.16.0-preview.3 and create version 0.16.0-preview.4 (google-gemini#13143) Co-authored-by: Tommaso Sciortino <[email protected]>
… to patch version v0.16.0-preview.4 and create version 0.16.0-preview.5 (google-gemini#13229) Co-authored-by: Jacob Richman <[email protected]>
Co-authored-by: Adam Weidman <[email protected]> Co-authored-by: Sehoon Shon <[email protected]> Co-authored-by: Adib234 <[email protected]> Co-authored-by: Sandy Tao <[email protected]> Co-authored-by: Abhi <[email protected]> Co-authored-by: Aishanee Shah <[email protected]> Co-authored-by: gemini-cli-robot <[email protected]> Co-authored-by: Gal Zahavi <[email protected]> Co-authored-by: Jacob Richman <[email protected]> Co-authored-by: joshualitt <[email protected]> Co-authored-by: Jenna Inouye <[email protected]>
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Summary of ChangesHello @jason43211, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the Gemini CLI by integrating Gemini 3 Pro, revamping the settings and model selection experience, and improving error handling for model interactions. It introduces new documentation pages for Gemini 3 and a comprehensive settings reference, alongside updates to existing CLI and IDE integration guides. These changes aim to provide users with more control over their CLI experience, better transparency regarding model usage, and a smoother interaction with advanced AI models. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a significant number of changes for the 3.0 release, including support for Gemini 3 preview models, a new settings system, dynamic UI banners, and greatly improved error and fallback handling. The changes are extensive and well-structured. I've identified one potential high-severity issue related to error handling for the new preview models that could affect the application's resilience. Overall, this is a solid update with many valuable improvements.
| const isContentError = error instanceof InvalidStreamError; | ||
|
|
||
| if (isContentError) { | ||
| if (isContentError && isGemini2Model(model)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The retry logic for InvalidStreamError is now restricted to only apply to Gemini 2.x models. This means that if a preview model (like Gemini 3) produces an invalid stream (e.g., a tool call without a finish reason), the request will fail immediately without any retries. Given that preview models can sometimes have unexpected behavior, removing this resilience mechanism could lead to a less stable experience for users on the preview track. Consider re-enabling this retry logic for all models or specifically for preview models to improve robustness.
Summary
Details
Related Issues
How to Validate
Pre-Merge Checklist