Skip to content

Conversation

@afarber
Copy link
Contributor

@afarber afarber commented Dec 6, 2025

Summary

Remove incorrectly documented general.sessionRetention from settings reference. This container/namespace setting has showInDialog: false and was never meant to appear in the UI or docs.

Details

The sessionRetention setting is a container object that groups related settings (enabled, maxAge, maxCount, minRetention). Only its child sessionRetention.enabled has showInDialog: true and appears in the /settings UI. The docs had an extra row documenting the parent container as if it were a standalone setting.

Related Issues

Fixes #14623

How to Validate

  1. Open docs/cli/settings.md and verify general.sessionRetention row is gone
  2. Verify general.sessionRetention.enabled row is still present
  3. Run gemini and type /settings - the "Enable Session Cleanup" option should be visible under General (unchanged behaviour)

Pre-Merge Checklist

  • Updated relevant documentation and README (if needed)
  • Added/updated tests (if needed)
  • Noted breaking changes (if any)
  • Validated on required platforms/methods:
    • MacOS
      • npm run
      • npx
      • Docker
      • Podman
      • Seatbelt
    • Windows
      • npm run
      • npx
      • Docker
    • Linux
      • npm run
      • npx
      • Docker

@afarber afarber requested a review from a team as a code owner December 6, 2025 10:27
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @afarber, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines the documentation for session retention settings by removing an entry that was erroneously included. The change ensures that the settings reference accurately reflects which settings are visible in the user interface and intended for user interaction, thereby improving the clarity and correctness of the documentation.

Highlights

  • Documentation Correction: Removed the general.sessionRetention entry from the docs/cli/settings.md file, as it was incorrectly documented.
  • Setting Visibility: The general.sessionRetention setting is a container/namespace with showInDialog: false, meaning it should not appear in the UI or documentation. Only its child setting, general.sessionRetention.enabled, is intended for display.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly removes the general.sessionRetention setting from the CLI settings documentation. This setting is a container object not intended for direct user interaction, and its removal from the documentation aligns with its showInDialog: false property in the settings schema. The change makes the documentation accurately reflect the settings presented in the UI. The modification is confined to the documentation and is appropriate and correct.

@afarber afarber force-pushed the 14623-fix-session-retention-doc branch 3 times, most recently from 9ed9cc4 to 9533775 Compare December 9, 2025 13:49
@afarber afarber force-pushed the 14623-fix-session-retention-doc branch from 9533775 to 31d331e Compare December 9, 2025 19:53
@gemini-cli gemini-cli bot added size/s A small PR review/quick PRs that may be easy to review. labels Dec 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

review/quick PRs that may be easy to review. size/s A small PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Doc/UI Mismatch] "Session Retention" setting is missing from /settings UI but present in documentation

1 participant