Skip to content

Conversation

@Weaxs
Copy link

@Weaxs Weaxs commented Dec 7, 2025

Summary

a2a-server add settings paramrters

Details

  • fileFiltering.respectGeminiIgnore
  • fileFiltering.disableFuzzySearch
  • modelConfigs

Related Issues

no issues

How to Validate

  1. add params in settings.json
{
    "fileFiltering": {
        "respectGeminiIgnore": true,
        "disableFuzzySearch": true
    },
    "modelConfigs": {
        "aliases": {
            "base": {
                "modelConfig": {
                    "generateContentConfig": {
                        "temperature": 0,
                        "topP": 1
                    }
                }
            },
            "chat-base": {
                "extends": "base",
                "modelConfig": {
                    "generateContentConfig": {
                        "thinkingConfig": {
                            "includeThoughts": true
                        },
                        "temperature": 1,
                        "topP": 0.95,
                        "topK": 64
                    }
                }
            },
            "chat-base-2.5": {
                "extends": "chat-base",
                "modelConfig": {
                    "generateContentConfig": {
                        "thinkingConfig": {
                            "thinkingBudget": 8192
                        }
                    }
                }
            },
            "chat-base-3": {
                "extends": "chat-base",
                "modelConfig": {
                    "generateContentConfig": {
                        "thinkingConfig": {
                            "thinkingLevel": "HIGH"
                        }
                    }
                }
            },
            "gemini-3-pro-preview": {
                "extends": "chat-base-3",
                "modelConfig": {
                    "model": "gemini-3-pro-preview",
                    "httpOptions": {
                        "baseUrl": "https://example.com/v1"
                    }
                }
            },
            "gemini-2.5-pro": {
                "extends": "chat-base-2.5",
                "modelConfig": {
                    "model": "gemini-2.5-pro"
                }
            },
            "gemini-2.5-flash": {
                "extends": "chat-base-2.5",
                "modelConfig": {
                    "model": "gemini-2.5-flash"
                }
            },
            "gemini-2.5-flash-lite": {
                "extends": "chat-base-2.5",
                "modelConfig": {
                    "model": "gemini-2.5-flash-lite"
                }
            },
            "gemini-2.5-flash-base": {
                "extends": "base",
                "modelConfig": {
                    "model": "gemini-2.5-flash"
                }
            }
        }
    }
}

}

Pre-Merge Checklist

  • Updated relevant documentation and README (if needed)
  • Added/updated tests (if needed)
  • Noted breaking changes (if any)
  • Validated on required platforms/methods:
    • MacOS
      • npm run
      • npx
      • Docker
      • Podman
      • Seatbelt
    • Windows
      • npm run
      • npx
      • Docker
    • Linux
      • npm run
      • npx
      • Docker

@Weaxs Weaxs requested a review from a team as a code owner December 7, 2025 04:17
@google-cla
Copy link

google-cla bot commented Dec 7, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @Weaxs, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the configurability of the a2a-server by introducing new settings for file filtering and AI model management. Users can now specify whether to respect Gemini-specific ignore files, disable fuzzy search for files, and define complex model configurations, including aliases and generation parameters. This change provides greater control and flexibility over the server's behavior and its interaction with AI models.

Highlights

  • Enhanced File Filtering Options: The a2a-server now supports new file filtering settings, respectGeminiIgnore and disableFuzzySearch, allowing for more granular control over which files are processed or ignored.
  • Flexible Model Configuration: Support for modelConfigs has been added, enabling users to define and manage various AI model configurations, including aliases and specific generation parameters like temperature and topP.
  • New Type and Service Export: A new type, ModelConfigServiceConfig, has been introduced and the modelConfigService.js module is now exported from the @google/gemini-cli-core package to support the new model configuration capabilities.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds support for several new settings in the a2a-server: respectGeminiIgnore, disableFuzzySearch, and modelConfigs. The changes look good overall, but there's a critical issue with how the respectGeminiIgnore setting is being handled. The property name in the Settings interface is inconsistent with its usage in settings.json and the schema, which will prevent it from being loaded correctly. I've left specific comments with suggestions to fix this.

@Weaxs Weaxs changed the title a2a-server support respectGeminiIgnore/disableFuzzySearch/modelConfigs a2a-server support geminiIgnore/disableFuzzySearch/modelConfigs Dec 7, 2025
@Weaxs Weaxs changed the title a2a-server support geminiIgnore/disableFuzzySearch/modelConfigs a2a-server support respectGeminiIgnore/disableFuzzySearch/modelConfigs Dec 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant