Skip to content

feat: Return List instead of ImmutableList in CallbackUtil methods #1063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
copybara-service merged 1 commit into from
Mar 20, 2026
+6 −4
Merged

feat: Return List instead of ImmutableList in CallbackUtil methods #1063

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions core/src/main/java/com/google/adk/agents/BaseAgent.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -529,7 +529,8 @@ public B beforeAgentCallback(BeforeAgentCallback beforeAgentCallback) {

@CanIgnoreReturnValue
public B beforeAgentCallback(List<Callbacks.BeforeAgentCallbackBase> beforeAgentCallback) {
this.beforeAgentCallback = CallbackUtil.getBeforeAgentCallbacks(beforeAgentCallback);
this.beforeAgentCallback =
ImmutableList.copyOf(CallbackUtil.getBeforeAgentCallbacks(beforeAgentCallback));
return self();
}

Expand All @@ -541,7 +542,8 @@ public B afterAgentCallback(AfterAgentCallback afterAgentCallback) {

@CanIgnoreReturnValue
public B afterAgentCallback(List<Callbacks.AfterAgentCallbackBase> afterAgentCallback) {
this.afterAgentCallback = CallbackUtil.getAfterAgentCallbacks(afterAgentCallback);
this.afterAgentCallback =
ImmutableList.copyOf(CallbackUtil.getAfterAgentCallbacks(afterAgentCallback));
return self();
}

Expand Down
4 changes: 2 additions & 2 deletions core/src/main/java/com/google/adk/agents/CallbackUtil.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ public final class CallbackUtil {
* @return normalized async callbacks, or empty list if input is null.
*/
@CanIgnoreReturnValue
public static ImmutableList<BeforeAgentCallback> getBeforeAgentCallbacks(
public static List<BeforeAgentCallback> getBeforeAgentCallbacks(
List<BeforeAgentCallbackBase> beforeAgentCallbacks) {
return getCallbacks(
beforeAgentCallbacks,
Expand All @@ -59,7 +59,7 @@ public static ImmutableList<BeforeAgentCallback> getBeforeAgentCallbacks(
* @return normalized async callbacks, or empty list if input is null.
*/
@CanIgnoreReturnValue
public static ImmutableList<AfterAgentCallback> getAfterAgentCallbacks(
public static List<AfterAgentCallback> getAfterAgentCallbacks(
List<AfterAgentCallbackBase> afterAgentCallback) {
return getCallbacks(
afterAgentCallback,
Expand Down
Loading