fix: URL-encode userId and sessionId in VertexAiClient#1072
Open
Tulgaaaaaaaa wants to merge 2 commits intogoogle:mainfrom
Open
fix: URL-encode userId and sessionId in VertexAiClient#1072Tulgaaaaaaaa wants to merge 2 commits intogoogle:mainfrom
Tulgaaaaaaaa wants to merge 2 commits intogoogle:mainfrom
Conversation
User-supplied userId and sessionId values were concatenated directly into Vertex AI REST API URL paths and query parameters without encoding. This allows query parameter injection via userId (e.g., "attacker&extra_param=value") and path manipulation via sessionId (e.g., "../../other-resource"). Apply URLEncoder.encode() to all user-supplied values before URL construction in listSessions, listEvents, getSession, deleteSession, and appendEvent. Bug: CWE-116 (Improper Encoding or Escaping of Output)
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
10 tests covering all 5 methods that construct URLs with user-supplied values. Verifies query parameter injection (& = characters), path traversal (../ sequences), and normal values pass through correctly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
VertexAiClient.javaconcatenatesuserIdandsessionIddirectly into Vertex AI REST API URL paths and query parameters without encoding.For example in
listSessions():A
userIdcontaining&or=characters can inject additional query parameters. AsessionIdcontaining/or..can manipulate the URL path structure.Fix
encodeParam()helper usingURLEncoder.encode(value, StandardCharsets.UTF_8)userIdinlistSessionsandsessionIdinlistEvents,getSession,deleteSession, andappendEventreasoningEngineIdis already validated byparseReasoningEngineId()regex (digits only)Tests added
VertexAiClientTest.java— 10 tests covering all 5 methods:user&extra=value→user%26extra%3Dvalue)../../secret→..%2F..%2Fsecret)