Closed
Conversation
glaforge
force-pushed
the
feature/parallel-agent
branch
from
a2d57a4 to
c84be11
Compare
krwc
approved these changes
Mar 23, 2026
| long duration = System.currentTimeMillis() - startTime; | ||
|
|
||
| assertThat(events).hasSize(2); | ||
| // If parallel, duration should be less than 1.5 * sleepTime (1500ms). |
There was a problem hiding this comment.
I think it'd be better to use locks / cvars to test this.
I won't block the submission on it, but relying on sleeps tends to lead to test flakiness.
glaforge
force-pushed
the
feature/parallel-agent
branch
3 times, most recently
from
899b2f2 to
2b63184
Compare
tilgalas
approved these changes
Mar 23, 2026
…text management - Implement ParallelAgent for concurrent sub-agent execution - Add branch propagation logic for invocation context management - Fix branch name initialization in BaseAgent
glaforge
force-pushed
the
feature/parallel-agent
branch
from
2b63184 to
fd92efd
Compare
|
We will resolve this in #1077. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #610 as a test was failing:
The test was failing because the branch was empty. This happened because the
BaseAgentwould only "append" its name to an existing branch. If the root agent was started with no branch (which is common in tests), its context—and subsequently its sub-agents' contexts—remained branchless.