Skip to content

fix: use placeholders for missing but required Event's fields #1075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
copybara-service wants to merge 1 commit into
base: main
Choose a base branch
from
+11 −8
Open

fix: use placeholders for missing but required Event's fields #1075

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 11 additions & 8 deletions core/src/main/java/com/google/adk/events/Event.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@
import java.util.Optional;
import java.util.Set;
import java.util.UUID;
import javax.annotation.Nullable;
import org.jspecify.annotations.Nullable;

// TODO - b/413761119 update Agent.java when resolved.
/** Represents an event in a session. */
Expand Down Expand Up @@ -344,11 +344,14 @@ public final String stringifyContent() {
/** Builder for {@link Event}. */
public static class Builder {

private String id;
private String invocationId;
private String author;
private static final String MISSING_INVOCATION_ID = "__adk__invocation__id__missing";
private static final String MISSING_AUTHOR = "__adk__author__unknown";

private @Nullable String id;
private @Nullable String invocationId;
private @Nullable String author;
private @Nullable Content content;
private EventActions actions;
private @Nullable EventActions actions;
private @Nullable Set<String> longRunningToolIds;
private @Nullable Boolean partial;
private @Nullable Boolean turnComplete;
Expand Down Expand Up @@ -522,9 +525,9 @@ public Builder modelVersion(@Nullable String value) {

public Event build() {
Event event = new Event();
event.setId(id);
event.setInvocationId(invocationId);
event.setAuthor(author);
event.setId(Optional.ofNullable(id).orElse(UUID.randomUUID().toString()));
event.setInvocationId(Optional.ofNullable(invocationId).orElse(MISSING_INVOCATION_ID));
event.setAuthor(Optional.ofNullable(author).orElse(MISSING_AUTHOR));
event.setContent(content);
event.setLongRunningToolIds(longRunningToolIds);
event.setPartial(partial);
Expand Down